Skip to content

Fix broken links in structure chaining docs - #2620

Open
guavovic wants to merge 2 commits into
dotnet:mainfrom
guavovic:fix/links-structure-chaining
Open

guavovic wants to merge 2 commits into
dotnet:mainfrom
guavovic:fix/links-structure-chaining

Conversation

@guavovic

@guavovic guavovic commented Oct 2, 2026

Copy link
Copy Markdown

Summary of the PR

There are nine broken links, and I'm fixing them in vulkan.md and structure-chaining.md, since they return a 404 (page not found) when opened. I checked them manually to confirm what was happening. The sources/*.html links in the OpenGL tutorial were left out.

The ../../src/... path points to a page that does not exist on the site, and the .cs files live in the repository, not on the site.

Related issues, Discord discussions, or proposals

Related to #2566

Further Comments

I opened the pages on the published site and saw the 404. I used managed-chaining.md as a model. The PR is just a draft for now.

@guavovic

guavovic commented Oct 2, 2026

Copy link
Copy Markdown
Author

@dotnet-policy-service agree

@guavovic
guavovic marked this pull request as ready for review October 2, 2026 04:56
@guavovic
guavovic requested a review from a team as a code owner October 2, 2026 04:56
@guavovic

guavovic commented Oct 2, 2026

Copy link
Copy Markdown
Author

Hi @Exanite! Could you please approve my build? Thank you!

@guavovic

guavovic commented Oct 4, 2026

Copy link
Copy Markdown
Author

@Perksey

Perksey commented Oct 4, 2026

Copy link
Copy Markdown
Member

Please note that none of the individuals you've pinged (apart from Exanite) are involved in Silk.NET development.

@Perksey

Perksey commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

I suppose we can merge this, but I'm a little concerned that the logic in the develop/3.0 branch (where the website building code lives) is meant to account for these relative paths - these relative paths not working is likely a bug. I'd much rather that be fixed.

@Exanite

Exanite commented Oct 4, 2026

Copy link
Copy Markdown
Member

I'm not sure what's going on with CI, but linking to Github is what we did in #2579 because relative paths lead to the file being downloaded and I believe linking to Github provides a better experience.

@guavovic

guavovic commented Oct 5, 2026

Copy link
Copy Markdown
Author

Sorry for the unnecessary pings, I didn't know who was on the team.

I followed the same approach as #2579 and the existing managed-chaining.md, which already link to GitHub.

About the CI: the Build job is failing while installing the Android SDK on the macOS runner (sdkmanager exits with code 1), so it doesn't seem related to this change, which only touches .md files.

If you'd rather go a different way, I'm happy to update the PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants