Repository navigation
Conversation
|
@dotnet-policy-service agree |
|
Hi @Exanite! Could you please approve my build? Thank you! |
|
Please note that none of the individuals you've pinged (apart from Exanite) are involved in Silk.NET development. |
|
I suppose we can merge this, but I'm a little concerned that the logic in the develop/3.0 branch (where the website building code lives) is meant to account for these relative paths - these relative paths not working is likely a bug. I'd much rather that be fixed. |
|
I'm not sure what's going on with CI, but linking to Github is what we did in #2579 because relative paths lead to the file being downloaded and I believe linking to Github provides a better experience. |
|
Sorry for the unnecessary pings, I didn't know who was on the team. I followed the same approach as #2579 and the existing managed-chaining.md, which already link to GitHub. About the CI: the Build job is failing while installing the Android SDK on the macOS runner (sdkmanager exits with code 1), so it doesn't seem related to this change, which only touches .md files. If you'd rather go a different way, I'm happy to update the PR. |
Summary of the PR
There are nine broken links, and I'm fixing them in
vulkan.mdandstructure-chaining.md, since they return a 404 (page not found) when opened. I checked them manually to confirm what was happening. Thesources/*.htmllinks in the OpenGL tutorial were left out.The
../../src/...path points to a page that does not exist on the site, and the.csfiles live in the repository, not on the site.Related issues, Discord discussions, or proposals
Related to #2566
Further Comments
I opened the pages on the published site and saw the 404. I used
managed-chaining.mdas a model. The PR is just a draft for now.