Tests | Refactor NativeVectorFloat32Tests for future Half support

[edwardneal]

Description

This is somewhat inspired by #4234. We don't yet have support for SqlVector<Half> and other types, but this should hopefully make the test logic trivial to add.

I'd recommend moving commit by commit - the introduction of a base class has resulted in the PR looking much larger than it truly is.

The overall design is now more generic. We have:

• NativeVectorTestDataBase<TElement>, which contains test data for SqlVector<TElement>
• NativeVectorTestsBase<TElement, TTestData>, which contains the test logic and links it to the test data
• VectorFloat32TestData: derived from NativeVectorTestDataBase which contains float-based sample data
• NativeVectorFloat32Tests: the same tests and the same logic as in main, but derived from NativeVectorTestsBase

Adding future support for Half should mean simply introducing VectorFloat16TestData and NativeVectorFloat16Tests classes:

public sealed class VectorFloat16TestData : NativeVectorTestDataBase<Half>
{
    public override Half[] SampleScalarData => [1, 2, 3, 4, 5, 6];

    public override Half[,] SampleDataSet => /* */;

    public override int IncorrectScalarDataParameterSize => 9999;

    public override bool IsSupported => DataTestUtility.IsSqlVectorFloat16Supported;

    public override string SqlServerTypeName => "float16";
}

public sealed class NativeVectorFloat16Tests : NativeVectorTestsBase<Half, VectorFloat16TestData>
{
}

I've also made a handful of hygiene improvements, but none are particularly controversial:

• Use of RAII primitives
• Text corrections in comments
• Assertion cleanups (catching an exception and running Assert.Fail, performing Assert.True(!verifyReader.IsDBNull(0), ...), etc.)
• Nullability annotations

Issues

In lieu of any more specific issue for Half/float16 support for SqlVector, this contributes to #3444.

Testing

All automated tests continue to pass.

[apoorvdeshmukh]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[Copilot]

Pull request overview

Refactors the native SqlVector<T> manual test suite to use a generic test-data + shared test-logic base, so adding future element types (e.g., Half) becomes mostly a matter of adding a new *TestData + thin derived test class.

Changes:

• Adds NativeVectorTestDataBase<TElement> to centralize per-element sample data and parameter-pattern cases.
• Adds NativeVectorTestsBase<TElement, TTestData> to host the shared insertion/read, stored-proc, bulk-copy, and prepare/execute test logic using RAII DB objects.
• Refactors the float32 suite into VectorFloat32TestData + NativeVectorFloat32Tests : NativeVectorTestsBase<...>.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/VectorTest/NativeVectorTestsBase.cs	New generic base classes for vector manual tests + shared test logic and RAII-managed DB objects.
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/VectorTest/NativeVectorFloat32Tests.cs	Refactors float32 tests into new test-data class + thin derived test class using the new base.

[edwardneal]

The default vector base type is float32, so vector(N, float32) is a more explicit name for vector(N). We explicitly specify the base type rather than implementing a special case.

[edwardneal]

The default vector base type is float32, so vector(N, float32) is a more explicit name for vector(N). We explicitly specify the base type rather than implementing a special case.

[edwardneal]

Fixed in 07c2ae1.

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).

[apoorvdeshmukh]

Nice refactor — this generalizes cleanly. One small thing: the row count here is hardcoded to 10, while the loop above is data-driven off SampleDataSet. Since the point of this base class is to let future element types (e.g. a SqlVector<Half> suite) supply their own SampleDataSet with a potentially different row count, this assertion couples the base back to float[10, N].

Suggest deriving it from the data so it stays element-agnostic:

Suggested change

	Assert.Equal(10, rowcnt);
	Assert.Equal(sampleDataSet.GetLength(0), rowcnt);

[edwardneal]

That makes sense, thanks - fixed in c2d227d.

[apoorvdeshmukh]

Just one minor suggestion. Looks good to me otherwise.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.56%. Comparing base (5ac26c9) to head (07c2ae1).
⚠️ Report is 67 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4347      +/-   ##
==========================================
- Coverage   66.50%   63.56%   -2.95%     
==========================================
  Files         285      280       -5     
  Lines       43311    66783   +23472     
==========================================
+ Hits        28806    42450   +13644     
- Misses      14505    24333    +9828     

Flag	Coverage Δ
CI-SqlClient	?
PR-SqlClient-Project	63.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.