Document AndroidMessageHandler redirects - #555
Conversation
Refs #278 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Xamarin.Android.Net API XML documentation to describe redirect-related behavior on Xamarin.Android.Net.AndroidMessageHandler, replacing “To be added.” placeholders with concrete documentation.
Changes:
- Documented
AllowAutoRedirectto describe redirect-following behavior and its default value. - Documented
SupportsRedirectConfigurationto explain support for redirect configuration via related properties.
Suppressed comments (1)
docs/xml/Xamarin.Android.Net/AndroidMessageHandler.xml:943
- This property’s block drops the and elements, which makes it inconsistent with the rest of the properties in this file and may produce incomplete property documentation output.
Gets a value indicating whether the handler supports configuration settings for the
<see cref="P:Xamarin.Android.Net.AndroidMessageHandler.AllowAutoRedirect" /> and
<see cref="P:Xamarin.Android.Net.AndroidMessageHandler.MaxAutomaticRedirections" /> properties.
Always returns <c>true</c> for <see cref="T:Xamarin.Android.Net.AndroidMessageHandler" />.
</summary>
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refs #278 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
@dalexsoto review |
1 similar comment
|
@dalexsoto review |
dalexsoto
left a comment
There was a problem hiding this comment.
The property documentation structure is fixed, but both new remarks point readers to HttpURLConnection.InstanceFollowRedirects even though AndroidMessageHandler always disables Java redirect handling and implements redirects itself through AllowAutoRedirect and MaxAutomaticRedirections. Please remove those links or explicitly explain the managed redirect mechanism: AndroidMessageHandler.xml.
Refs #278
Documents redirect handling without expanding into implementation-specific placeholder members.
Sources
Validation
docs/xml/Xamarin.Android.Net/*.xmlfiles withSystem.Xml.XmlReader.docs/xml/Xamarin.Android.Net.git diff --check.