Skip to content

Document AndroidMessageHandler redirects - #555

Open
jonathanpeppers wants to merge 2 commits into
mainfrom
jonathanpeppers-document-xamarin-android-net
Open

Document AndroidMessageHandler redirects#555
jonathanpeppers wants to merge 2 commits into
mainfrom
jonathanpeppers-document-xamarin-android-net

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Refs #278

Documents redirect handling without expanding into implementation-specific placeholder members.

Sources

Validation

  • Parsed all 6 docs/xml/Xamarin.Android.Net/*.xml files with System.Xml.XmlReader.
  • Verified 0 lone LF bytes in docs/xml/Xamarin.Android.Net.
  • Ran git diff --check.

Refs #278

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Xamarin.Android.Net API XML documentation to describe redirect-related behavior on Xamarin.Android.Net.AndroidMessageHandler, replacing “To be added.” placeholders with concrete documentation.

Changes:

  • Documented AllowAutoRedirect to describe redirect-following behavior and its default value.
  • Documented SupportsRedirectConfiguration to explain support for redirect configuration via related properties.
Suppressed comments (1)

docs/xml/Xamarin.Android.Net/AndroidMessageHandler.xml:943

  • This property’s block drops the and elements, which makes it inconsistent with the rest of the properties in this file and may produce incomplete property documentation output.
          Gets a value indicating whether the handler supports configuration settings for the
          <see cref="P:Xamarin.Android.Net.AndroidMessageHandler.AllowAutoRedirect" /> and
          <see cref="P:Xamarin.Android.Net.AndroidMessageHandler.MaxAutomaticRedirections" /> properties.
          Always returns <c>true</c> for <see cref="T:Xamarin.Android.Net.AndroidMessageHandler" />.
        </summary>

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/xml/Xamarin.Android.Net/AndroidMessageHandler.xml
Refs #278

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

1 similar comment
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property documentation structure is fixed, but both new remarks point readers to HttpURLConnection.InstanceFollowRedirects even though AndroidMessageHandler always disables Java redirect handling and implements redirects itself through AllowAutoRedirect and MaxAutomaticRedirections. Please remove those links or explicitly explain the managed redirect mechanism: AndroidMessageHandler.xml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants