Document Java security spec key contracts - #557
Merged
Conversation
Refs #228 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 15, 2026 14:39
jonathanpeppers
enabled auto-merge (squash)
August 15, 2026 14:39
There was a problem hiding this comment.
Pull request overview
This PR updates the API reference XML documentation for Java.Security.Spec to explicitly document NullPointerException contracts for the “modern” EdEC/XEC key-spec constructors, aligning the docs with the upstream AOSP Java specifications.
Changes:
- Add
NullPointerException<exception>entries forXECPublicKeySpecandXECPrivateKeySpecconstructors when required arguments arenull. - Add
NullPointerException<exception>entries forEdECPublicKeySpecandEdECPrivateKeySpecconstructors when required arguments arenull.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/xml/Java.Security.Spec/XECPublicKeySpec.xml | Documents NullPointerException for null params/u constructor arguments. |
| docs/xml/Java.Security.Spec/XECPrivateKeySpec.xml | Documents NullPointerException for null params/scalar constructor arguments. |
| docs/xml/Java.Security.Spec/EdECPublicKeySpec.xml | Documents NullPointerException for null params/point constructor arguments. |
| docs/xml/Java.Security.Spec/EdECPrivateKeySpec.xml | Documents NullPointerException for null params/bytes constructor arguments. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
@dalexsoto review |
1 similar comment
Member
Author
|
@dalexsoto review |
dalexsoto
approved these changes
Aug 16, 2026
dalexsoto
left a comment
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The four EdEC/XEC constructor exception contracts match the Android and Java specifications, with complete managed-signature parity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NullPointerExceptioncontracts for the four modern EdEC/XEC key-spec constructors.Sources
Validation
git diff --check.Refs #228