Document BufferedInputStream fields - #562
Merged
Merged
Conversation
Refs #237 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 15, 2026 14:56
jonathanpeppers
enabled auto-merge (squash)
August 15, 2026 14:56
There was a problem hiding this comment.
Pull request overview
This PR updates the XML documentation for Java.IO.BufferedInputStream to replace placeholder <value> entries with concrete descriptions for several Android-backed protected fields/properties.
Changes:
- Filled in
<value>documentation forbuf,count,marklimit,markpos, andposinBufferedInputStream.xml. - Reduced “To be added.” placeholders in the
Java.IOXML docs set (scoped to the edited file/entries).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Refs #237 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and removed request for
dalexsoto
August 15, 2026 15:07
Member
Author
|
@dalexsoto review |
dalexsoto
approved these changes
Aug 16, 2026
dalexsoto
left a comment
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The BufferedInputStream field contracts now use the correct byte-oriented terminology, and the accepted generated-member scope remains intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the Android-backed BufferedInputStream protected field values for �uf, count, marklimit, markpos, and pos.
Refs #237
Sources
Validation
eturns, and param To be added. entries): Java.IO 769 before, 764 after; edited file 7 before, 2 after. The remaining two in BufferedInputStream.xml are generated JniPeerMembers binding entries and were intentionally left undocumented.