Document Android.Systems StructTimeval conversions - #563
Merged
jonathanpeppers merged 2 commits intoAug 16, 2026
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 15, 2026 14:59
jonathanpeppers
enabled auto-merge (squash)
August 15, 2026 14:59
There was a problem hiding this comment.
Pull request overview
This PR updates the generated XML documentation for Android.Systems.StructTimeval to describe its millisecond conversion helpers and field semantics, using Android’s reference docs plus immutable AOSP source anchors for behavior details.
Changes:
- Documented
StructTimeval.FromMillis(long)including negative-value conversion behavior and an AOSP source link. - Documented
StructTimeval.ToMillis()conversion formula and added an AOSP source link. - Replaced placeholder
<value>docs forTvSecandTvUsecwith concrete component descriptions.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
@dalexsoto review |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and removed request for
dalexsoto
August 15, 2026 15:10
Member
Author
|
@dalexsoto review |
1 similar comment
Member
Author
|
@dalexsoto review |
dalexsoto
approved these changes
Aug 16, 2026
dalexsoto
left a comment
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The StructTimeval conversion documentation now matches AOSP behavior, including integer-division truncation, and no blocking issue remains.
jonathanpeppers
deleted the
jonathanpeppers-document-android-systems-0fa
branch
August 16, 2026 01:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StructTimeval.FromMillis,StructTimeval.ToMillis,TvSec, andTvUsec.Sources
Validation
docs/xml/Android.Systems/StructTimeval.xml.git diff --checkpassed.FromMillis,ToMillis,TvSec, andTvUsec; 9 unrelated infrastructure placeholders remain in the file.Refs #248