Document ByteBuffer primitive reads - #566
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
requested review from
dalexsoto
and
a lite review from Copilot
August 15, 2026 15:01
jonathanpeppers
enabled auto-merge (squash)
August 15, 2026 15:01
There was a problem hiding this comment.
Pull request overview
This PR improves the Java.Nio.ByteBuffer XML documentation by replacing To be added. placeholders with concrete return-value descriptions for the relative primitive-read properties, and by adding direct Android reference anchors for each documented member.
Changes:
- Replaced placeholder
<value>To be added.</value>text with specific return-value descriptions forChar,Double,Float,Int,Long, andShort. - Added Android reference links (exact anchors) in
<remarks>for each of those members.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
@dalexsoto review |
1 similar comment
Member
Author
|
@dalexsoto review |
dalexsoto
approved these changes
Aug 16, 2026
dalexsoto
left a comment
Member
There was a problem hiding this comment.
The ByteBuffer return contracts match the Android APIs and managed signatures, with complete source/generated parity and no remaining blocking issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ByteBufferrelative primitive-read properties:Char,Double,Float,Int,Long, andShort.Sources
Validation
docs/xml/Java.Nio/ByteBuffer.xmlas XML.lf-only=0,cr-only=0).git diff --check.To be added.occurrences inByteBuffer.xmlfrom 12 to 6; the remaining placeholders are outside this member scope.Refs #234