Skip to content

Document CheckBoxPreference overrides - #573

Open
jonathanpeppers wants to merge 1 commit into
mainfrom
jonathanpeppers-android-preferences-docs
Open

Document CheckBoxPreference overrides#573
jonathanpeppers wants to merge 1 commit into
mainfrom
jonathanpeppers-android-preferences-docs

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Refs #145

Sources

Validation

  • [xml](Get-Content -Raw 'docs\\xml\\Android.Preferences\\CheckBoxPreference.xml')
  • git diff --check
  • Confirmed the XML file retains CRLF working-tree line endings.

Documents four source-backed CheckBoxPreference override properties (eight placeholder fields). Twenty placeholders in this type and 293 across the remaining namespace are intentionally left for later sourced slices.

Refs #145

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the API reference XML for Android.Preferences.CheckBoxPreference by replacing placeholder documentation with sourced summaries/values for several override properties, aligning this type’s documentation more closely with the upstream Android reference and the existing TwoStatePreference docs in the repo.

Changes:

  • Replaced To be added. placeholders with concrete <summary>/<value> text for Checked.
  • Added concrete <summary>/<value> text for DisableDependentsState.
  • Added concrete <summary>/<value> text for SummaryOffFormatted and SummaryOnFormatted.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SetSummaryOff(int) and SetSummaryOn(int) are public overrides but still retain To be added. summaries and parameter docs, leaving the stated override-documentation work incomplete. Please document both resource overloads, including summaryResId, and link them to the formatted summary properties: CheckBoxPreference.xml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants