Simplify publishing output paths by lbussell · Pull Request #2208 · dotnet/docker-tools

lbussell · 2026-08-07T20:32:24Z

The pipeline artifacts from the publish stage aren't consumed anywhere (that I could find). Yet, we upload them in three separate publish artifact tasks. That's a waste of time.

All commands use BuildConfiguration.ArtifactStagingDirectory for build artifact publishing and consumption. All input/output paths are relative to this directory. This is through a new abstraction, ArtifactService.
Publishes all artifacts just one time at the very end of the publish stage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Keep current shared templates on the published ImageBuilder contract while bundling the relative output paths with the next ImageBuilder release. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

mthalman · 2026-08-10T15:02:05Z

+    {
+        if (string.IsNullOrWhiteSpace(_buildConfig.ArtifactStagingDirectory))
+        {
+            throw new InvalidOperationException(


Any call to ResolvePath will fail in the context of a PR build because generate-appsettings.yml skips outputting an appsettings.json file for PRs:

docker-tools/eng/docker-tools/templates/steps/generate-appsettings.yml

Line 34 in ffecd62

condition: and(succeeded(), ne(variables['Build.Reason'], 'PullRequest'), ${{ parameters.condition }})

So no ArtifactStagingDirectory value will be set, causing this exception to throw.

lbussell and others added 30 commits August 7, 2026 10:59

Add artifact output service

45d274f

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Resolve merge output from artifact staging

59945ee

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Resolve EOL data output from artifact staging

a49b685

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Resolve annotation output from artifact staging

a1d49e7

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Document artifact output contract

d4d56e3

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Remove redundant output path check

b268151

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Simplify output directory creation

95f1a8c

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Resolve output directories through filesystem

5b4d9c8

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Clarify artifact path resolution

b40d37a

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Remove null suppression from output paths

caab7cd

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Keep lexical paths outside filesystem abstraction

119b8bb

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Write EOL outputs through shared service

55aea77

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Explain artifact path resolution

ca741ed

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Generalize artifact path service

4c7b638

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Resolve trim input from artifact staging

d16ca4c

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Resolve copy input from artifact staging

13a2133

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Resolve manifest list input from artifact staging

633a0d7

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Resolve merge inputs from artifact staging

0c6ae8b

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Resolve Kusto input from artifact staging

7a4e5fb

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Resolve EOL inputs from artifact staging

bb4b1de

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Resolve image info publish input

e7506d3

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Resolve notification input from artifact staging

7395818

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Resolve ingestion input from artifact staging

547c5a0

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Resolve annotation input from artifact staging

9dd8cce

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Use artifact-relative publish inputs

e3fa0f7

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Resolve annotation ingestion input

a5e290a

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Use relative annotation ingestion input

78798e8

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Consolidate publish stage artifacts

ac76b37

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Use artifact terminology in path resolution

1be9918

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

lbussell added 9 commits August 7, 2026 10:59

Default annotation upload switch to false

c12d061

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Clarify publish artifact attempt name

365117e

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Shorten publish artifact display name

3bfaae2

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Require paths within artifact staging

4bde9d8

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Clarify artifact service purpose

08c2732

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Document artifact path behavior

0d909e4

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Don't overwrite options

ede1020

Simplify artifact test helper setup

da28f90

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c0f6c174-1904-42d2-8829-bc3cd05e05d0

Always upload artifacts

fa3f544

lbussell marked this pull request as ready for review August 7, 2026 20:44

lbussell requested a review from a team as a code owner August 7, 2026 20:44

mthalman reviewed Aug 10, 2026

View reviewed changes

Navigation Menu

Uh oh!

Simplify publishing output paths - #2208

Simplify publishing output paths#2208
lbussell wants to merge 39 commits into
mainfrom
lbussell/simplify-publish-output-paths

lbussell commented Aug 7, 2026

Uh oh!

mthalman Aug 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

lbussell commented Aug 7, 2026

Uh oh!

mthalman Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants