-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add reference to Zip/Tar best practices to ExractToDirectory #12995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rzikm
wants to merge
3
commits into
main
Choose a base branch
from
tar-zip-best-practices
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43
−35
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| > [!WARNING] | ||
| > This method must be used only on trusted archives as it doesn't enforce any size limits, entry count limits, or other policies needed for safe extraction of untrusted archives. Refer to [Best practices for using zip and tar archives](/dotnet/standard/io/zip-tar-best-practices) for more information on safely extracting archives from untrusted sources. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -492,6 +492,11 @@ | |
| <para>Files of type <see cref="F:System.Formats.Tar.TarEntryType.BlockDevice" />, <see cref="F:System.Formats.Tar.TarEntryType.CharacterDevice" />, or <see cref="F:System.Formats.Tar.TarEntryType.Fifo" /> can only be extracted in Unix platforms.</para> | ||
| <para>Elevation is required to extract a <see cref="F:System.Formats.Tar.TarEntryType.BlockDevice" /> or <see cref="F:System.Formats.Tar.TarEntryType.CharacterDevice" /> to disk.</para> | ||
| <para>This method doesn't limit the total extracted size or the number of entries extracted from the archive. When processing archives from untrusted sources, iterate over the entries manually using <see cref="T:System.Formats.Tar.TarReader" />, and validate that the size and the number of entries are within acceptable limits for your scenario.</para> | ||
| <format type="text/markdown"><] | ||
|
|
||
| ]]></format> | ||
| </remarks> | ||
| <exception cref="T:System.ArgumentNullException"> | ||
| <paramref name="source" /> or <paramref name="destinationDirectoryName" /> is <see langword="null" />.</exception> | ||
|
|
@@ -536,7 +541,13 @@ Extracting one of the tar entries would have resulted in a file outside the spec | |
| <param name="destinationDirectoryName">To be added.</param> | ||
| <param name="options">To be added.</param> | ||
| <summary>To be added.</summary> | ||
| <remarks>To be added.</remarks> | ||
| <remarks> | ||
| <format type="text/markdown"><] | ||
|
|
||
| ]]></format> | ||
| </remarks> | ||
| </Docs> | ||
| </Member> | ||
| <Member MemberName="ExtractToDirectory"> | ||
|
|
@@ -574,6 +585,11 @@ Extracting one of the tar entries would have resulted in a file outside the spec | |
| <para>Files of type <see cref="F:System.Formats.Tar.TarEntryType.BlockDevice" />, <see cref="F:System.Formats.Tar.TarEntryType.CharacterDevice" />, or <see cref="F:System.Formats.Tar.TarEntryType.Fifo" /> can only be extracted in Unix platforms.</para> | ||
| <para>Elevation is required to extract a <see cref="F:System.Formats.Tar.TarEntryType.BlockDevice" /> or <see cref="F:System.Formats.Tar.TarEntryType.CharacterDevice" /> to disk.</para> | ||
| <para>This method doesn't limit the total extracted size or the number of entries extracted from the archive. When processing archives from untrusted sources, iterate over the entries manually using <see cref="T:System.Formats.Tar.TarReader" />, and validate that the size and the number of entries are within acceptable limits for your scenario.</para> | ||
| <format type="text/markdown"><] | ||
|
|
||
| ]]></format> | ||
| </remarks> | ||
| <exception cref="T:System.ArgumentNullException"> | ||
| <paramref name="sourceFileName" /> or <paramref name="destinationDirectoryName" /> is <see langword="null" />.</exception> | ||
|
|
@@ -615,7 +631,13 @@ Extracting one of the tar entries would have resulted in a file outside the spec | |
| <param name="destinationDirectoryName">To be added.</param> | ||
| <param name="options">To be added.</param> | ||
| <summary>To be added.</summary> | ||
| <remarks>To be added.</remarks> | ||
| <remarks> | ||
| <format type="text/markdown"><] | ||
|
|
||
| ]]></format> | ||
| </remarks> | ||
| </Docs> | ||
| </Member> | ||
| <MemberGroup MemberName="ExtractToDirectoryAsync"> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.