Modernize C# code snippets (System.Data) - #13027
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Modernizes selected System.Data C# API documentation snippets with current syntax and formatting.
Changes:
- Applies target-typed construction, collection expressions, interpolation, and pattern matching.
- Converts the
AsEnumerablesample to top-level statements and an executable project. - Corrects the
DataColumnarray initialization inadd1.cs.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
snippets/csharp/System.Data/DataTableExtensions/AsEnumerable/source.cs |
Modernizes sample structure and syntax. |
snippets/csharp/System.Data/DataTableExtensions/AsEnumerable/Project.csproj |
Configures the sample as an executable. |
snippets/csharp/System.Data/DataTable/Overview/source.cs |
Modernizes formatting and initializers. |
snippets/csharp/System.Data/ConstraintCollection/Overview/constraintcollection.cs |
Modernizes constraints and iteration syntax. |
snippets/csharp/System.Data/ConstraintCollection/Add/add4.cs |
Uses collection expressions and interpolation. |
snippets/csharp/System.Data/ConstraintCollection/Add/add3.cs |
Modernizes formatting and interpolation. |
snippets/csharp/System.Data/ConstraintCollection/Add/add2.cs |
Normalizes formatting. |
snippets/csharp/System.Data/ConstraintCollection/Add/add1.cs |
Corrects column collection initialization. |
snippets/csharp/System.Data/ConstraintCollection/Add/add.cs |
Uses target-typed construction. |
snippets/csharp/System.Data/Constraint/ToString/tostring.cs |
Normalizes formatting. |
snippets/csharp/System.Data/Constraint/Table/table.cs |
Normalizes formatting and braces. |
snippets/csharp/System.Data/Constraint/SetDataSet/setdataset.cs |
Uses target-typed construction. |
snippets/csharp/System.Data/Constraint/Overview/constraint.cs |
Modernizes pattern matching and iteration. |
snippets/csharp/System.Data/Constraint/ConstraintName/constraintname.cs |
Normalizes formatting and naming. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wadepickett
approved these changes
Aug 24, 2026
wadepickett
left a comment
wadepickett
left a comment
Contributor
There was a problem hiding this comment.
@gewarren: Approved. I'm not finding anything beyond what was already addressed. Looks great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #12713.
Internal previews
Toggle expand/collapse