Skip to content

Emit MethodImpl flags for property accessors - #20558

Open
T-Gro wants to merge 3 commits into
mainfrom
fix/issue-20288
Open

T-Gro wants to merge 3 commits into
mainfrom
fix/issue-20288

Conversation

@T-Gro

@T-Gro T-Gro commented Sep 15, 2026

Copy link
Copy Markdown
Member

Fixes #20288

Encode MethodImpl and PreserveSig attributes on property getters and setters as method implementation flags instead of ordinary custom attributes.

Copilot added 2 commits September 15, 2026 15:08
Create one self-contained sprint for issue #20288 with raw metadata regressions, the surgical partition move, local validation, and commit-only delivery.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 0a3927ad-5349-4e6f-81eb-435aad67f0dc
Decode implementation flags before separating accessor attributes, preserving ordinary attribute routing and existing decoder behavior. Add raw-metadata regressions, compatibility controls, diagnostic checks and external-call coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: ffa8facb-33f4-430a-8b15-ff25b03841bc
@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

❗ Release notes required

You can open this PR in browser to add release notes: open in github.dev


✅ Found changes and release notes in following paths:

Change path Release notes path Description
`src/Compiler` docs/release-notes/.FSharp.Compiler.Service/11.0.100.md

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b12329be-d120-43cd-baaa-0a0683e64c00
@github-actions github-actions Bot added the AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed label Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

MethodImpl attribute is silently dropped on property accessors (and leaks into metadata as a real custom attribute)

1 participant