Skip to content

Fix misleading diagnostics for reordered record fields - #20559

Open
T-Gro wants to merge 5 commits into
mainfrom
fix/issue-20410
Open

T-Gro wants to merge 5 commits into
mainfrom
fix/issue-20410

Conversation

@T-Gro

@T-Gro T-Gro commented Sep 15, 2026

Copy link
Copy Markdown
Member

Fixes #20410

Avoid the misleading FS0193 name-mismatch error when record fields have different declaration orders in a signature and its implementation. Preserve FS0312 and genuine field-mismatch diagnostics.

Copilot and others added 2 commits September 15, 2026 15:11
Create one self-contained implementation sprint with RED/GREEN coverage, raw diagnostic assertions, local validation, review, and commit-only delivery.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d19ba29f-8295-468b-af28-e0590fcd57bd
Guard positional record checks by logical name before calling checkField. Preserve FS0312, matching-name checks, and complete warning multiplicity. Add RED-first paired-source coverage and a compiler-service release note.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 17b0ddb3-0fbb-4b25-b9e8-d3bf1e9d6de9
@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

❗ Release notes required

You can open this PR in browser to add release notes: open in github.dev


✅ Found changes and release notes in following paths:

Change path Release notes path Description
`src/Compiler` docs/release-notes/.FSharp.Compiler.Service/11.0.100.md

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7477690c-d85c-4d8d-87f4-579d2acae391
@github-actions github-actions Bot added the AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed label Sep 15, 2026
Copilot and others added 2 commits September 16, 2026 01:34
Replace the completed compiler implementation sprint with one self-contained CI recovery sprint based on build 1597638. Preserve the existing guard, tests, and release note; require diagnosis, complete Release/net472 batch coverage, local review, and commit-only delivery.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 852fa0ba-f0ae-4405-8299-c6a8b51d1feb
Reuse the existing three-batch test template to avoid running the legacy desktop suite alongside the other test projects. Preserve the 120-minute timeout, no-realsig and metadata flags, environment, and compiler regression coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f0d4ef4c-beb9-46d3-811a-38e35489e05f
@T-Gro
T-Gro requested a review from abonie September 16, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

Misleading extra error message when field declaration order differs between signature & implementation

1 participant