Repository navigation
[cDAC][wasm] Filter unexpected register slots in non-active frames - #135093
Merged
radekdoulik merged 2 commits intoOct 8, 2026
Merged
Conversation
Treat unexpected Wasm register slots as scratch, with a concise rationale and matching contract clarification. Preserve active-frame behavior and all encoding constants. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
lewing
approved these changes
Oct 2, 2026
This was referenced Oct 2, 2026
Closed
jkotas
reviewed
Oct 2, 2026
Jan Kotas noted that returning true from IsScratchRegister diverges from the native unknown-platform fallback, which asserts and returns false (gcinfodecoder.cpp PORTABILITY_ASSERT). Mirror that: Debug.Fail to flag the unreachable call in debug builds, then return false like the native helper and other unimplemented platforms. Update the matching contract-spec sentence. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
rcj1
approved these changes
Oct 7, 2026
Member
Author
|
/ba-g the failures are unrelated/preexisting None of the latest CI failures is related to our Wasm change.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to Larry Ewing's review comment on #135055.
Wasm GC info must not contain register slots. Update
WasmGCInfoTraits.IsScratchRegisterto callDebug.Failand returnfalse, matching the native decoder fallback. Thefalsereturn preserves existing fallback behavior; valid Wasm GC info decoding, active-frame behavior, encoding constants, andHAS_INTERRUPTIBLE_RANGESare unchanged.Also document this invariant in the GCInfo contract specification. No generic decoder, interpreter, stack-walker, or test source changes are included.
Validation
No native/runtime/browser rebuild or live Wasm demo was run.
Note
This PR description was updated with GitHub Copilot.