Repository navigation
[cDAC][wasm] Expose the WebAssembly function identity of R2R frames #135495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+405
−3
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
77a1c5f
[cDAC][wasm] Expose the WebAssembly function identity of R2R frames
lewing eb98533
[cDAC][wasm] Add pseudocode for GetWasmFunctionIdentity
lewing 0b2a14c
Merge origin/main into lewing-cdac-wasm-function-identity
lewing 325c1f6
Simplify WasmFunctionTableIndexLookup.TryGetFunctionIdentity
lewing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the need for this new API?
We currently have APIs to access the Module, check if a code region is a funclet, and get the
RUNTIME_FUNCTIONaddress. If there is a reason we need the index, I believe that should be done in IExecutionManager.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, it isn't needed. The pieces already exist:
GetCodeBlockHandle,IsFunclet,GetUnwindInfo/TryGetUnwindInfofor the RUNTIME_FUNCTION, and the module from the frame's MethodDesc. The CDP consumer that motivated this matches cDAC frames to engine frames by stack pointer and already decodes R2R RUNTIME_FUNCTION indices on its own, so it doesn't use this API either. Closing this PR. If an image-relative index turns out to be needed later, it will go inIExecutionManageras you suggest.Note
This reply was generated with GitHub Copilot.
Auto-replied by the GitHub Copilot app