Repository navigation
Add PR-supplied EgorBot vetting to microbenchmark skill - #136076
Open
eiriktsarpalis wants to merge 1 commit into
Open
eiriktsarpalis wants to merge 1 commit into
eiriktsarpalis wants to merge 1 commit into
Conversation
Add a canonical-first PR vetting route that dispatches focused EgorBot requests and stops after posting. Preserve existing metadata and local and legacy EgorBot workflows. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9d231e5d-da7c-48a1-a069-50667b1ecc98
|
Azure Pipelines: Successfully started running 1 pipeline(s). 15 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
|
||
| ## Explicitly Supplied PR | ||
|
|
||
| When the user supplies a PR URL to vet its performance, use [PR-supplied EgorBot vetting](references/pr-vetting.md) instead of the local steps and legacy EgorBot guidance below, unless the user explicitly requests local-only measurements. That workflow selects benchmarks, posts the EgorBot invocation comment(s) on the supplied PR, and stops without waiting for results. |
Member
There was a problem hiding this comment.
This general skill and usage probably needs weigh-in from @EgorBo. It has the risk of automatically incurring a lot of additional overhead for something which is not a team owned, costed, or scaled utility.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing microbenchmark workflow starts with custom benchmarks and local builds. Add a dedicated route for vetting an explicitly supplied PR URL through EgorBot, reusing canonical dotnet/performance benchmarks before considering custom code.
The route supports open
dotnet/runtimePRs targetingmainand uses EgorBot's default current-main-versus-merged-PR comparison. Existing skill metadata, local-only measurements, and legacy EgorBot behavior without a supplied PR URL are preserved.Validation: Skill metadata and whitespace checks passed. Four fixture-driven dry-run scenarios passed all 24 assertions; the non-PR/local-only preservation control passed against both the original and updated skill. No live EgorBot jobs or benchmark comments were created during evaluation. No runtime builds or benchmarks were run for this skill-documentation change.
Note
This pull request description and the changes were generated with GitHub Copilot.