Unify logging pattern in browser refresh middleware. - #56006
Open
tmat wants to merge 3 commits into
Open
Conversation
Prefix messages with "refresh" emoji so that they stand out.
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates dotnet-watch’s BrowserRefreshMiddleware logging to route more messages through the existing LoggerMessage.Define pattern and prefixes those messages with a refresh symbol to make them more visually distinctive in output.
Changes:
- Replaced constructor and header-related
LogDebugcalls with strongly-typedLog.*methods. - Prefixed multiple browser refresh middleware log messages with a refresh symbol via a shared
Symbolconstant. - Added new
LoggerMessage.Defineentries for missing header/environment-variable debug messages.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
Author
genlu
reviewed
Aug 28, 2026
| { | ||
| private const string Symbol = "🔃"; | ||
|
|
||
| private static readonly Action<ILogger, string?, string?, Exception?> _middlewareLoaded = LoggerMessage.Define<string?, string?>( |
Member
There was a problem hiding this comment.
nit: put this after _scriptInjectionSkipped below to preserve the order of event ID
genlu
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefix messages with "refresh" emoji so that they stand out.