lib-index: mail-index-sync-update - Check header update record size - #306
Open
nishat-06 wants to merge 1 commit into
Open
lib-index: mail-index-sync-update - Check header update record size#306nishat-06 wants to merge 1 commit into
nishat-06 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mail_index_sync_record_real() applies MAIL_TRANSACTION_HEADER_UPDATE records from dovecot.index.log without checking that a sub-record's declared size fits within the transaction, so sync_header_update() reads u->size bytes past the end of a truncated record and copies them into the index header. This record type isn't covered by log_view_is_record_valid(), and the sibling EXT_HDR_UPDATE cases already guard it, so add the same size check before applying the update. Includes a regression test that trips the over-read under ASAN/valgrind.