lib-index: mail-cache-lookup - Fix OOB read of unterminated header - #307
Open
nishat-06 wants to merge 1 commit into
Open
lib-index: mail-cache-lookup - Fix OOB read of unterminated header#307nishat-06 wants to merge 1 commit into
nishat-06 wants to merge 1 commit into
Conversation
header_lines_save() scans a cached header field's leading uint32 line numbers for the 0 terminator and then copies the header text that follows from pos = (lines_count+1)*4. A corrupted dovecot.index.cache field whose size is not a multiple of 4 and that never contains the terminator makes pos run past field->size, so the following memcpy reads a few bytes beyond the field. Bail out and flag the cache corrupted when the terminator is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
header_lines_save() scans a cached header field's leading uint32 line numbers for the 0 terminator and then copies the header text that follows from pos = (lines_count+1)*4. A corrupted dovecot.index.cache field whose size is not a multiple of 4 and that never contains the terminator makes pos run past field->size, so the following memcpy reads a few bytes beyond the field. Bail out and flag the cache corrupted when the terminator is missing, before computing that offset.