auth: db-oauth2 - require all configured scopes in token - #308
Open
nishat-06 wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi, this is tracked internally as a critical vulnerability. Please contact security@dovecot.org before opening potential security fixes. We can leave this open now, as there is no point to retract this anymore from here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
db_oauth2_token_in_scope() treats oauth2_scope as any-of: the loop breaks as soon as the token carries one of the configured scopes, so a token missing the rest still authenticates in introspection and tokeninfo modes. The JWT local-validation path (check_scope in lib-oauth2/oauth2-jwt.c) already requires every configured scope, and test-oauth2-jwt covers that behavior. Fail when any configured scope is absent so both validation paths enforce the setting the same way.