Honor explicit start offsets in load - #117
Merged
Merged
Conversation
Owner
|
Ooh, good catch! I can't believe I didn't write tests for this when I added the feature :(. Nice tests, also :). |
dpranke
marked this pull request as ready for review
October 1, 2026 19:38
Owner
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Honor the documented absolute
startargument inload(): when it is explicitly supplied, seek to zero before reading the full content and delegate the decoded-content offset toparse().Currently,
load()reads from the stream's existing position and appliesstartto that shortened content. This can silently change numeric values, as well as reject a valid document after the stream has been read to EOF.The existing
load()docstring explicitly distinguishesstart=Nonefrom an explicit offset and requires a seekable stream for the latter.The two-line guard preserves the default:
start=Nonecontinues reading from the current stream position without callingseek(). Explicitstart=0also follows the documented seek requirement. Negative/out-of-range offset handling andconsume_trailingbehavior remain delegated to the existing parser.Verification
123 != 23and123 != 3git diff --checkpassedAI disclosure: An OpenAI coding assistant investigated, authored, and tested this patch, with independent review by another assistant, under the account owner's authorization to contribute to open-source projects.