Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: NValsan <15096090+NValsan@users.noreply.github.com>
…aces Co-authored-by: NValsan <15096090+NValsan@users.noreply.github.com>
Co-authored-by: NValsan <15096090+NValsan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix homepage explainer video build playback issue
Fetch and verify Git LFS assets before Hugo builds
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The homepage explainer video (
docs/assets/video/drasi-explainer-30s.mp4, added in #271) is tracked with Git LFS. In environments that clone without an LFS checkout, the file on disk is a 132-byte pointer; Hugo'sresources.Getpublishes it without error, so the build succeeds while the site serves unplayable text.The failure is silent — the only real fix is to guarantee LFS objects are materialized before Hugo runs, and to fail loudly when they aren't.
New check
scripts/verify-lfs-assets.shfails if any LFS-tracked file is still a pointer, using the checkout marker fromgit lfs ls-files:It requires no network and reports remediation steps.
CI
website.yaml: added a verification step after checkout (which already setslfs: true), before any Hugo step.test.yaml: checkout was missinglfs: trueeven though the job runshugo— added, plus the verification step.Local / devcontainer
Makefile: newlfs(install + pull + verify) andcheck-lfs(offline verify) targets.serve,preview-tutorials,preview-docsandbuildnow depend oncheck-lfs, so they fail fast with instructions instead of rendering a broken video. Deliberately not depending onlfs, to keep offline iteration working..devcontainer/devcontainer.json:postCreateCommandpulls and verifies LFS objects before the submodule init.readme.md: Git LFS listed as a prerequisite, with setup and verification steps.The video shortcode and asset are untouched; this only changes how builds obtain the asset. Since #271 is not yet merged, the check is generic over all LFS-tracked files and starts covering the MP4 as soon as that PR lands.
Verified against #271's content: Hugo builds and
public/video/drasi-explainer-30s.mp4is the real 1,513,496-byte MP4 (sha256 matches the pointer oid); with the pointer in place, Hugo still "succeeds" but publishes 132 bytes, while the new check exits 1.