Add some sanitization for paths, switch QRCode renderer to SvgPathImage - #2
Open
garyg1 wants to merge 3 commits into
Open
Add some sanitization for paths, switch QRCode renderer to SvgPathImage#2garyg1 wants to merge 3 commits into
garyg1 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this is just a local script, but technically you can write to arbitrary directories on the system (including .. and ./cgi-bin).
I made a fork adding some basic logic to check this.
Any chance you'd be willing to incorporate this into your upstream, as well? I'm happy to license this patch under the same MIT license as your repo.
Changes
SvgImagewithSvgPathImage, because somehowSvgImagedoesn't render for me in Chromium 150. If it's just my machine I can revert.Here's a repro. I know very little about CGI, so there may be paths I missed.
And thanks for making this, it's very useful to me.