[Feature] Endpoint presets#4028
Draft
peterschmidt85 wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Creating a reliable model service requires selecting a model variant, serving configuration, and
hardware, then validating that combination. The result cannot currently be saved and reused as a
local endpoint recipe.
Change
See the Endpoints concept page for the proposed UX.
WIP
final_report.json.modelwithout checkingwhich repo/path the final service command loads. A preset can therefore advertise a different
model from the one it deploys.
final_report.json.context_lengthwithout verifying it against thefinal service. An overstated value can make the recipe match endpoint requirements it does not
satisfy.
final_report.json.service_yamlis required for success but is never parsed or used. InvalidYAML currently has no effect on preset creation.
fleets, backends, regions, spot policy, and maximum price. Preset creation can succeed after the
agent violates the endpoint request.
submissions.jsonl. A run submittedbefore the journal entry is written can remain running and continue consuming resources.
failure but leaves the recipe in the local store.
terminates preset creation with
ValueError.token,key,secret, orpasswordas secret. Benign values such asTOKENIZERS_PARALLELISM=falsearechanged into unresolved environment references.
vllm/vllm-openai:latest. Reusing thepreset can then run serving code different from what its validation evidence covered.
AttributeErrorinstead of a useful CLI error.~/.dstack/presets, but the stored format has no versionor migration contract for future dstack releases.
Reused run names then make the evidence ambiguous.
api.client._tokenfield,coupling the command to an internal client implementation detail.
commands can race despite individual file replacement being atomic.
/and\\with--. Arbitrary base names can collide and canstill contain filename characters invalid on Windows.
recipe ID. It has no defined performance, price, or quality selection policy.
prints that group again, producing duplicated and potentially confusing output.
AI assistance
AI assistance was used for implementation, tests, documentation, and E2E investigation.