Include action name and form data in action approval emails - #15
Draft
suraj-ranganath wants to merge 1 commit into
Draft
Include action name and form data in action approval emails#15suraj-ranganath wants to merge 1 commit into
suraj-ranganath wants to merge 1 commit into
Conversation
Approver and requester emails for human-gated actions were generic unless the reviewer opened the request. Persist Action Name plus submitted form data on access requests, render both emails from that payload, and surface the details in the control room. Co-authored-by: c1-squire-dev[bot] <c1-squire-dev[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Approver and requester emails for requestable actions were too generic to act on without opening the request. Approvers could not see the action being asked for, and requesters saw copy that just said an "action" was submitted.
This change:
Approver subject:
Approval needed: {Action Name}Requester subject:
{Action Name} submitted for approvalCustomer evidence
Testing
12 tests covering action names, form-data extraction/redaction, approver/requester copy, HTML escaping, and request enrichment.