Support --no-coverage and --profile=coverage#42
Open
YoannChabert wants to merge 2 commits into
Open
Conversation
…punit/php-code-coverage v14 HTML colors - Extension: coverage is now disabled by the legacy --no-coverage flag or enabled by an explicit --profile=coverage, so both older and newer Behat setups keep working. - Extension: keep parenthesized `new` expressions so the code still runs on PHP 8.3 (the parenthesis-less form needs 8.4+). - ReportService: import Composer\Semver\VersionParser instead of using the FQCN inline, and pass through the new *Dark/*Bar color config keys expected by phpunit/php-code-coverage's HTML report. - EventSubscriber: drop unused event parameters from afterScenario/afterExercise. - docs: bump idna and urllib3 lockfile entries.
The idna/urllib3 bumps were fork-local dependabot updates, unrelated to this PR's actual fixes.
YoannChabert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extension: coverage collection is now disabled by the legacy--no-coverageflag, or enabled by an explicit--profile=coverage, so both older Behat setups (using--no-coverage) and newer profile-based setups keep working.ReportService: importComposer\Semver\VersionParserinstead of the inline FQCN, and pass through the additional*Dark/*Bar/breadcrumbs*color config keys expected by the currentphpunit/php-code-coverageHTML report (Colors::from()).EventSubscriber: drop unused event parameters fromafterScenario/afterExercise.Test plan
--no-coveragestill skips coverage--profile=coverage(and no--no-coverage) collects coverage