Add concepts/classes for NumPy-style type promotions - #633
Merged
Merged
Conversation
arcondello
commented
Sep 9, 2026
| // allowed by NumPy promotion. | ||
| /// Create an one interval from another, allowing for safe type promotions | ||
| template <can_cast<T> U> | ||
| constexpr interval(const interval<U>& other) noexcept : |
Member
Author
There was a problem hiding this comment.
No release note needed for this change because the interval class is not yet released.
Also there are other interval methods that might benefit from type promotion, but I've decided to leave those alone for now.
arcondello
marked this pull request as ready for review
September 9, 2026 15:17
fastbodin
self-requested a review
September 21, 2026 23:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next step after #632 is to support binary ops. But for that, we need to codify our type promotion rules (following NumPy as usual).
I also used the new type promotion concept in the interval class added in #626, mostly to show the pattern.
AI Generation Disclosure
Used Claude to review the code. No major changes from that review.