Complete sample overload signatures - #87
Open
danielgaskins wants to merge 1 commit into
Open
danielgaskins wants to merge 1 commit into
danielgaskins wants to merge 1 commit into
Conversation
Signed-off-by: Daniel Gaskins <danielgaskins99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes #28
What does this implement/fix?
Lists every keyword-only
sample()parameter in both overloads instead of hiding them behind**kwargs. TheLiteral[True]andLiteral[False]annotations still narrow the return type totorch.Tensorordimod.SampleSet.This also adds a release note.
Additional information
python3 -m pytest -q tests/test_boltzmann_machine.py(27 passed, 6 subtests passed)python3 -m pytest -q --deselect='tests/test_samplers/test_base.py::TestTorchSampler::test_parameters'(156 passed, 70 subtests passed)reno lintmain.AI Generation Disclosure
I used Codex to inspect the overloads, update the signatures, draft the release note, and run validation. I reviewed the changes and test results before submitting.