feat(devtime): add dev server startup time metric - #434
Merged
Merged
Conversation
43081j
approved these changes
Aug 30, 2026
43081j
left a comment
43081j
left a comment
Contributor
There was a problem hiding this comment.
seems good to me but lets wait for @AlexanderKaran to review too
AlexanderKaran
approved these changes
Sep 3, 2026
Collaborator
|
Sorry @dreyfus92 for the delay. Was doing schema thinking and final got to a place which I am happy with and this will not effect it |
Resolve conflicts from the build output size removal (e18e#440): keep the devServerStartTime field next to the build stats in types.ts and content.config.ts, drop buildOutputSize. Satisfy the new Knip config (e18e#445): LOOPBACK_ADDRESSES and DevServerExit are only used inside dev-server.ts, so they are no longer exported, and the `pnpm dev` spawn is ignored as a binary the same way `pnpm build` is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a dev server startup benchmark for every starter. It copies the tracked files into a temp dir, installs with a frozen lockfile outside the
timedregion, runspnpm dev, and times until the firstGET /returns 200. this considers 5 runs as requested.starters aren't touched. ports live in
frameworks.jsonasdevServerPort.things I hit while toying with this:
localhost, which fetch() won't let you set, so the readiness probe usesnode:http.localhostresolves to, so the probe races 127.0.0.1 and ::1.tables will be populated after this lands and the ci runs 😄
closes: #206