Conversation
Adds QuorumSlotResponse and a fetch_from_quorum broadcast method to the existing interface, plus the pre_resolve_slots declaration it backs.
Leader-only pre-resolution of every slot <= upto not yet confirmed present or Empty, before proposing SyncRSCommitLSN. Broadcasts via fetch_from_quorum and aggregates responses order-independently (Empty beats data regardless of which member is processed first), writing locally-missing data into this leader's own journal and minting fresh Empty verdicts where the quorum has no evidence.
sbinmalek
changed the title
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unbounded candidate generation, unsafe failure accounting, malformed-response handling, and concurrent journal writes can violate resolution safety.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/v6.x #183 +/- ##
===========================================
Coverage ? 49.14%
===========================================
Files ? 19
Lines ? 1229
Branches ? 538
===========================================
Hits ? 604
Misses ? 268
Partials ? 357 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sbinmalek
force-pushed
the
SDSTOR-22907
branch
from
September 23, 2026 14:45
adfa220 to
2fec89e
Compare
sbinmalek
marked this pull request as ready for review
September 23, 2026 14:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before a CRAFT leader proposes a
SyncRSCommitLSN(upto)RAFT entry, it must resolve every slot<= uptonot yet confirmed present or Empty on the quorum -- otherwise the leader could proposepast a hole no one has resolved.
CraftReplDev::pre_resolve_slots(upto): computes candidates as the union of known localgaps (
missing_lsns_ <= upto) and slots beyond this leader's own append frontier thatuptoreaches past (e.g. a client
Resolvenaming a dLSN this leader never received, or a loginrs_commit_lsnthat is the quorum's max, not this replica's own).CraftPeerFetcher::fetch_from_quorumand aggregates every responding No changes this sessionmember's reply order-independently: Empty beats data regardless of which member is processed
first, a slot no member reports data or Empty for is quorum-lacks-evidence (minted fresh as
Empty), and a slot some member has real data for is written into this leader's own journal.
Zero responding members (a documented normal outcome of the interface, distinct from "some
members responded with no evidence") fails closed rather than minting Empty verdicts with no
evidence behind them.
member's reply, not the whole broadcast.
append()/request_resolution()(both remain stubs) -- that's SDSTOR-22908.