Skip to content

Assert no console instances are existing before and after console tests #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iloveeclipse merged 1 commit into from
Aug 4, 2026
Merged

Assert no console instances are existing before and after console tests #2852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/ConsoleExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
/*******************************************************************************
* Copyright (c) 2026 Andrey Loskutov <loskutov@gmx.de> and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
* which accompanies this distribution, and is available at
* https://www.eclipse.org/legal/epl-2.0/
*
* SPDX-License-Identifier: EPL-2.0
*******************************************************************************/
package org.eclipse.debug.tests;

import static org.junit.jupiter.api.Assertions.assertEquals;

import java.util.Arrays;

import org.eclipse.ui.console.ConsolePlugin;
import org.eclipse.ui.console.IConsole;
import org.eclipse.ui.console.IConsoleManager;
import org.junit.jupiter.api.extension.AfterEachCallback;
import org.junit.jupiter.api.extension.BeforeEachCallback;
import org.junit.jupiter.api.extension.ExtensionContext;

public class ConsoleExtension implements BeforeEachCallback, AfterEachCallback {

@Override
public void beforeEach(ExtensionContext context) throws Exception {
IConsole[] consoles = getConsoleManager().getConsoles();
assertEquals(0, consoles.length, "Should have no consoles before test, but found: " + Arrays.toString(consoles));
}

@Override
public void afterEach(ExtensionContext context) throws Exception {
removeAllConsoles();
}

private static void removeAllConsoles() {
IConsoleManager consoleManager = getConsoleManager();
consoleManager.removeConsoles(consoleManager.getConsoles());
IConsole[] consoles = consoleManager.getConsoles();
assertEquals(0, consoles.length, "Should have no consoles after test, but found: " + Arrays.toString(consoles));
}

private static IConsoleManager getConsoleManager() {
return ConsolePlugin.getDefault().getConsoleManager();
}

}
3 changes: 2 additions & 1 deletion debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/console/ConsoleManagerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import java.util.concurrent.Executors;
import java.util.concurrent.TimeUnit;

import org.eclipse.debug.tests.ConsoleExtension;
import org.eclipse.debug.tests.DebugTestExtension;
import org.eclipse.debug.tests.TestUtil;
import org.eclipse.swt.widgets.Display;
Expand All @@ -42,7 +43,7 @@
* Tests console manager behavior when multiple consoles are shown at the same
* time.
*/
@ExtendWith(DebugTestExtension.class)
@ExtendWith({ DebugTestExtension.class, ConsoleExtension.class })
public class ConsoleManagerTests {

private ExecutorService executorService;
Expand Down
3 changes: 2 additions & 1 deletion debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/console/ConsoleShowHideTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import static org.junit.jupiter.api.Assertions.assertNotSame;
import static org.junit.jupiter.api.Assertions.assertSame;

import org.eclipse.debug.tests.ConsoleExtension;
import org.eclipse.debug.tests.DebugTestExtension;
import org.eclipse.debug.tests.TestUtil;
import org.eclipse.swt.widgets.Display;
Expand All @@ -39,7 +40,7 @@
* Tests console manager's show/hide behavior when multiple consoles are shown
* in the console view.
*/
@ExtendWith(DebugTestExtension.class)
@ExtendWith({ DebugTestExtension.class, ConsoleExtension.class })
public class ConsoleShowHideTests {

private IConsoleManager manager;
Expand Down
142 changes: 74 additions & 68 deletions debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/console/ConsoleTests.java
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/console/IOConsoleTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
import org.eclipse.core.runtime.Platform;
import org.eclipse.core.runtime.Status;
import org.eclipse.core.runtime.jobs.Job;
import org.eclipse.debug.tests.ConsoleExtension;
import org.eclipse.debug.tests.DebugTestExtension;
import org.eclipse.debug.tests.TestUtil;
import org.eclipse.debug.tests.TestsPlugin;
Expand Down Expand Up @@ -78,7 +79,7 @@
/**
* Tests the {@link IOConsole}. Especially the partitioner and viewer parts.
*/
@ExtendWith(DebugTestExtension.class)
@ExtendWith({ DebugTestExtension.class, ConsoleExtension.class })
public class IOConsoleTests {

/**
Expand Down
10 changes: 2 additions & 8 deletions ...g.eclipse.debug.tests/src/org/eclipse/debug/tests/console/ProcessConsoleManagerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import java.util.Set;
import java.util.stream.Stream;

import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.jobs.Job;
import org.eclipse.debug.core.DebugPlugin;
import org.eclipse.debug.core.ILaunch;
Expand All @@ -34,6 +33,7 @@
import org.eclipse.debug.internal.ui.views.console.ConsoleRemoveAllTerminatedAction;
import org.eclipse.debug.internal.ui.views.console.ProcessConsole;
import org.eclipse.debug.internal.ui.views.console.ProcessConsoleManager;
import org.eclipse.debug.tests.ConsoleExtension;
import org.eclipse.debug.tests.DebugTestExtension;
import org.eclipse.debug.tests.TestUtil;
import org.eclipse.debug.ui.IDebugUIConstants;
Expand All @@ -49,7 +49,7 @@
/**
* Tests the ProcessConsoleManager.
*/
@ExtendWith(DebugTestExtension.class)
@ExtendWith({ DebugTestExtension.class, ConsoleExtension.class })
public class ProcessConsoleManagerTests {

private final PreferenceMemento prefMemento = new PreferenceMemento();
Expand All @@ -70,12 +70,6 @@ public void testProcessConsoleLifecycle(TestInfo testInfo) throws Exception {
DebugUIPlugin.getDefault();
final ILaunchManager launchManager = DebugPlugin.getDefault().getLaunchManager();
final IConsoleManager consoleManager = ConsolePlugin.getDefault().getConsoleManager();
final int existingNumConsoles = consoleManager.getConsoles().length;
if (existingNumConsoles > 0) {
// existing consoles must not harm this test but it may be
// interesting in case the test fails
TestUtil.log(IStatus.INFO, testInfo.getDisplayName(), "Found " + existingNumConsoles + " existing consoles on test start.");
}

ILaunch launch = null;
final MockProcess mockProcess = new MockProcess(MockProcess.RUN_FOREVER);
Expand Down
3 changes: 2 additions & 1 deletion debug/org.eclipse.debug.tests/src/org/eclipse/debug/tests/console/ProcessConsoleTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
import org.eclipse.debug.internal.ui.DebugUIPlugin;
import org.eclipse.debug.internal.ui.views.console.ConsoleMessages;
import org.eclipse.debug.internal.ui.views.console.ProcessConsole;
import org.eclipse.debug.tests.ConsoleExtension;
import org.eclipse.debug.tests.DebugTestExtension;
import org.eclipse.debug.tests.TestUtil;
import org.eclipse.debug.tests.launching.LaunchConfigurationTests;
Expand Down Expand Up @@ -88,7 +89,7 @@
/**
* Tests the ProcessConsole.
*/
@ExtendWith(DebugTestExtension.class)
@ExtendWith({ DebugTestExtension.class, ConsoleExtension.class })
public class ProcessConsoleTests {
/**
* Log messages with severity error received while running a single test
Expand Down
Loading