Event sample data type alignment fix

[NemanjaTrifunovicRTRK]

Added API for getting alignment of event data type.
Issue #852

Also fixed alignment of event data type in GatewayApplication.
Alignment was hardcoded to 0U, now it is collected from memory::DataTypeSizeInfo.
Issue #387

Documentation updated

• score/mw/com/dependability/software_architectural_design/mw_com_dii/README.md
• score/mw/com/design/skeleton_proxy/generic_proxy/generic_proxy_model.puml

Implementation extended:

• score/mw/com/gateway/gateway_application/gateway_application.cpp
• score/mw/com/impl/bindings/lola/generic_proxy_event.cpp
• score/mw/com/impl/bindings/lola/generic_proxy_event.h
• score/mw/com/impl/generic_proxy_event.cpp
• score/mw/com/impl/generic_proxy_event.h
• score/mw/com/impl/generic_proxy_event_binding.h

Tests updated:

• score/mw/com/impl/bindings/lola/generic_proxy_event_test.cpp
• score/mw/com/impl/bindings/mock_binding/generic_proxy_event.h
• score/mw/com/impl/generic_proxy_event_test.cpp

[limdor]

What are all these IDs added? like 14035185 or 31545523. They seem completly random

[NemanjaTrifunovicRTRK]

@limdor

What are all these IDs added? like 14035185 or 31545523. They seem completly random

Yes, it is random. I didn't find there is instructions for ID decision.
Inform me if these IDs should be created to have a specific value.
Thank you.

[btirunagaru]

Please fix the typos.

[limdor]

@limdor

What are all these IDs added? like 14035185 or 31545523. They seem completly random

Yes, it is random. I didn't find there is instructions for ID decision. Inform me if these IDs should be created to have a specific value. Thank you.

@NemanjaTrifunovicRTRK the ids are legacy from when we had this code internally. We will remove all these ids long term. For now, just do not add new IDs and make the linking via requirement name.
You can see an example on how it will look like in https://github.com/eclipse-score/communication/pull/952/changes

[NemanjaTrifunovicRTRK]

@limdor

What are all these IDs added? like 14035185 or 31545523. They seem completly random

Yes, it is random. I didn't find there is instructions for ID decision. Inform me if these IDs should be created to have a specific value. Thank you.

@NemanjaTrifunovicRTRK the ids are legacy from when we had this code internally. We will remove all these ids long term. For now, just do not add new IDs and make the linking via requirement name. You can see an example on how it will look like in https://github.com/eclipse-score/communication/pull/952/changes

@limdor, done.

[NemanjaTrifunovicRTRK]

Please fix the typos.

@btirunagaru, done.

[bemerybmw]

Please also squash the commits into a single commit with an informative message

[bemerybmw]

Can you please create a ticket to remove the deprecated function and link it here? I don't think we have a mechanism to deprecate requirements, so just adding a comment saying it's deprecated and linking the ticket would be fine.

[bemerybmw]

Please add a comment here linking the ticket to remove the deprecated requirement

[bemerybmw]

@NemanjaTrifunovicRTRK Please don't resolve the reviewer comments yourself. You can put a thumbs up or a comment indicating that you've addressed the comment and then the reviewer can resolve the comment once they've checked your change.

[bemerybmw]

You missed one comment. Apart from that, please squash the commits again. We shouldn't have merge commits. If you want to update the pr with latest master, then do a rebase instead of a merge:

[bemerybmw]

Please add a comment here linking the ticket to remove the deprecated requirement

[NemanjaTrifunovicRTRK]

You missed one comment. Apart from that, please squash the commits again. We shouldn't have merge commits. If you want to update the pr with latest master, then do a rebase instead of a merge:

@bemerybmw, thank you for the instructions.

I fixed it now, you can check.