Skip to content

fix: docs_bundle with local puml files - #742

Merged
a-zw merged 1 commit into
eclipse-score:mainfrom
etas-contrib:fix_canonical_mount_dir
Aug 21, 2026
Merged

fix: docs_bundle with local puml files#742
a-zw merged 1 commit into
eclipse-score:mainfrom
etas-contrib:fix_canonical_mount_dir

Conversation

@mariuswbr

Copy link
Copy Markdown
Contributor

📌 Description

_canonical_mount_dir incorrectly skipped symlink resolution for in-tree source bundles, causing a false-positive ExtensionError from sphinx-mounts' path confinement check when building in a Bazel sandbox. The fix removes the early-return guard so the file-following logic runs for all bundle types. Two unit tests are added covering the in-tree sandbox case and the empty-bundle fallback.

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@github-actions

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 5dc9cc33-09cc-4d4f-9ac0-dec0bf75953b
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
WARNING: Target pattern parsing failed.
ERROR: Skipping '//src:license-check': no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
ERROR: no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
INFO: Elapsed time: 5.872s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@MaximilianSoerenPollak

Copy link
Copy Markdown
Contributor

Can you point to where this actually breaks in your module? I'm a bit curious about these symlinked files how they look / etc.
Like the structure / tree of the folders etc.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes canonical mount resolution for same-workspace documentation bundles in Bazel sandboxes.

Changes:

  • Resolves mounted source-file symlinks for all bundle types.
  • Adds tests for in-tree sandbox bundles and empty-bundle fallback behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/extensions/score_mounts/__init__.py Extends canonical path resolution to in-tree bundles.
src/extensions/score_mounts/tests/test_data_mounts.py Tests symlink resolution and fallback behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@a-zw
a-zw merged commit 3172be5 into eclipse-score:main Aug 21, 2026
11 of 17 checks passed
@a-zw
a-zw deleted the fix_canonical_mount_dir branch August 21, 2026 15:02
@AlexanderLanin AlexanderLanin changed the title fix: Fix canonical_mount_dir for docs_bundle within the same workspace fix: docs_bundle with local puml files Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants