fix: docs_bundle with local puml files - #742
Merged
Merged
Conversation
mariuswbr
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
a-zw,
dcalavrezo-qorix and
nradakovic
as code owners
August 21, 2026 14:43
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
Contributor
|
Can you point to where this actually breaks in your module? I'm a bit curious about these symlinked files how they look / etc. |
There was a problem hiding this comment.
Pull request overview
Fixes canonical mount resolution for same-workspace documentation bundles in Bazel sandboxes.
Changes:
- Resolves mounted source-file symlinks for all bundle types.
- Adds tests for in-tree sandbox bundles and empty-bundle fallback behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/extensions/score_mounts/__init__.py |
Extends canonical path resolution to in-tree bundles. |
src/extensions/score_mounts/tests/test_data_mounts.py |
Tests symlink resolution and fallback behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
a-zw
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
_canonical_mount_dirincorrectly skipped symlink resolution for in-tree source bundles, causing a false-positive ExtensionError from sphinx-mounts' path confinement check when building in a Bazel sandbox. The fix removes the early-return guard so the file-following logic runs for all bundle types. Two unit tests are added covering the in-tree sandbox case and the empty-bundle fallback.🚨 Impact Analysis
✅ Checklist