Skip to content

qnx_ifs: migrate to score_rules_imagefs v0.0.3 rules_pkg-based API - #266

Draft
rmaddikery wants to merge 4 commits into
mainfrom
rama_fix_py_unittest_qnx_test
Draft

qnx_ifs: migrate to score_rules_imagefs v0.0.3 rules_pkg-based API#266
rmaddikery wants to merge 4 commits into
mainfrom
rama_fix_py_unittest_qnx_test

Conversation

@rmaddikery

@rmaddikery rmaddikery commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: a20763cd-1d21-4c33-ba0d-6838814901b9
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
Loading: 4 packages loaded
    currently loading: 
Loading: 5 packages loaded
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 11.523s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@rmaddikery
rmaddikery force-pushed the rama_fix_py_unittest_qnx_test branch from f18c972 to 0228cfe Compare August 21, 2026 08:21
@rmaddikery
rmaddikery force-pushed the rama_fix_py_unittest_qnx_test branch from 0228cfe to 2dab0b2 Compare August 21, 2026 08:38
@rmaddikery
rmaddikery force-pushed the rama_fix_py_unittest_qnx_test branch from 2dab0b2 to 2aaaabb Compare August 21, 2026 08:50
@rmaddikery
Adds py_unittest_qnx_test removed by baselibs
06b49ba 
- The wrapper is still needed to support the
exports from internal repo while still having
the tests executable.
- Adaptations require bumping the related deps
@rmaddikery
rmaddikery force-pushed the rama_fix_py_unittest_qnx_test branch from 2aaaabb to 4cae083 Compare August 21, 2026 09:24
@rmaddikery
rmaddikery force-pushed the rama_fix_py_unittest_qnx_test branch from 4cae083 to 363bf9f Compare August 21, 2026 09:35
@rmaddikery
qnx_ifs: migrate to score_rules_imagefs v0.0.3 rules_pkg-based API
d899fa0 
- qnx8_qemu env: replace the qnx8_qemu_env glob filegroup with pkg_files/
  pkg_filegroup targets (etc, ssh config/keys, scripts, config files),
  and expose system.build as a plain filegroup for extra_build_files.
- system.build / init.build: drop all ${MAIN_BUILD_FILE_DIR},
  ${DATAROUTER}, ${FILESYSTEM} substitutions; keep only SDP-root-relative
  static content.
- score/datarouter: add datarouter_bin_pkg (pkg_files) wrapping the
  datarouter binary for QNX image inclusion.
- score/test/component/datarouter: add datarouter_config_pkg; convert
  filetransfer_filesystem's pkg_tar chain to pkg_files/pkg_filegroup,
  keeping a pkg_tar output for the Docker path.
- logging_app, dlt_generator_app, filters_app: same pkg_tar ->
  pkg_files/pkg_filegroup conversion, each now exposing a
  *_filesystem_pkg target alongside the existing *_filesystem tar.
- defs.bzl: py_logging_itf_test now takes a required filesystem_pkg
  param; qnx_ifs() uses srcs + extra_build_files instead of the removed
  tars/ext_repo_maping attributes.
- mw_log/BUILD: pass filesystem_pkg at all three call sites.
@rmaddikery
rmaddikery force-pushed the rama_fix_py_unittest_qnx_test branch from 363bf9f to d899fa0 Compare August 21, 2026 09:59
@rmaddikery rmaddikery changed the title Adds py_unittest_qnx_test removed by baselibs qnx_ifs: migrate to score_rules_imagefs v0.0.3 rules_pkg-based API Aug 21, 2026
@rmaddikery
register aarch64 QNX IFS toolchain
d090cca 
- adds imagefs.toolchain() for aarch64, sdp_to_import
from score_qcc_aarch64_toolchain_pkg
@rmaddikery
rmaddikery force-pushed the rama_fix_py_unittest_qnx_test branch from 03ec1bf to 3af0b22 Compare August 21, 2026 12:00
@rmaddikery
Exclude aarch64 builds for qnx targets
6d9ed98 
- The aarch64 QNX SDP shipped by score_bazel_cpp_toolchains
is missing the startup-qemu-virt boot file needed by
score_qnx_unit_tests' QEMU image, hence QNX unit test suites
are skipped for this arch.
- bazel_cpp_toolchains/issues/124 linked for followup
- NOTE: subtracting a single target from a `:all`/`...` wildcard that also
matches it in the same invocation is unreliable (the target still gets
built); excluding the whole package and re-adding the wanted targets as
explicit positive patterns is the pattern that works reliably.
@rmaddikery
rmaddikery force-pushed the rama_fix_py_unittest_qnx_test branch from 3af0b22 to 6d9ed98 Compare August 21, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonkri antonkri Awaiting requested review from antonkri antonkri will be requested when the pull request is marked ready for review antonkri is a code owner
@4og 4og Awaiting requested review from 4og 4og will be requested when the pull request is marked ready for review 4og is a code owner
@pawelrutkaq pawelrutkaq Awaiting requested review from pawelrutkaq pawelrutkaq will be requested when the pull request is marked ready for review pawelrutkaq is a code owner
@arsibo arsibo Awaiting requested review from arsibo arsibo will be requested when the pull request is marked ready for review arsibo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

LOG - Logging FT
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rmaddikery