restructure: align module folder layout with score module folder structure - #386
Open
umaucher wants to merge 2 commits into
Open
restructure: align module folder layout with score module folder structure#386umaucher wants to merge 2 commits into
umaucher wants to merge 2 commits into
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
Removes the top-level /src and /tests folders and the cpp/rust language split, per eclipse-score/score#3194 (module folder structure DR): the src folder is optional and dropped, public interfaces live directly in score/<component>/, and internal/rust_kvs/rust_kvs_tool become lower_level_comp folders. Integration test suites move to score/kvs/tests/ since this module has a single component. Updates all Bazel targets, CI workflows, Cargo/pytest config, and docs that referenced the old paths, including the coverage targets newly introduced by #380.
umaucher
force-pushed
the
um_module_folder_structure
branch
from
August 21, 2026 14:11
cba54aa to
fcfe59f
Compare
pull_request_target always evaluates the workflow YAML from the base branch (main) while checking out the PR's source tree. Since this PR's branch lives in eclipse-score/persistency itself (not a fork), the build/docs/license-check checks kept running main's stale workflow copy against the restructured tree and failed on removed paths. Add a same-repo pull_request trigger alongside pull_request_target, gated so same-repo PRs run untrusted-secret-free via pull_request and fork PRs still require approval via pull_request_target.
Contributor
Author
|
all the failed jobs triggered by |
Contributor
Author
|
the generated documentation is in https://eclipse-score.github.io/persistency/pr-386/index.html |
umaucher
marked this pull request as ready for review
August 21, 2026 15:05
umaucher
requested review from
PandaeDo,
antonkri and
vinodreddy-g
as code owners
August 21, 2026 15:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns persistency with the score module folder structure DR (eclipse-score/score#3194): the module-level
srcfolder is optional and dropped, and language-split folders (cpp/rust) are replaced by a per-component layout.score/kvs/now holds the public C++ interface directly (nosrc/wrapper);internal/,rust_kvs/,rust_kvs_tool/are the component's<lower_level_comp>folders.score/kvs/tests/holds both the C++ unit tests and the integration test suites (test_scenarios/,test_cases/,integration_test_scenarios/), since this module has a single component and those suites test it specifically rather than spanning multiple components.src//tests/paths, including the targets newly introduced by coverage: adopt the unified LLVM coverage pipeline from score_tooling 2.1.1 #380 (quality/coverage,coverage.yml,release.yml).Note:
release.yml's "Run Unit Test with Coverage for Rust" step already called a//:rust_coveragetarget that no longer exists after #380 removed it in favour of the unified coverage pipeline — that regression predates this PR and is left untouched here as out of scope.