Skip to content

fix(common.pest): prevent arrow_direction from greedily matching identifier prefixes #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
castler merged 1 commit into from
Aug 20, 2026
Merged

fix(common.pest): prevent arrow_direction from greedily matching identifier prefixes #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions ...rser/integration_test/component_diagram/relation_alias_starts_with_d_no_decor/output.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
{
"relation_alias_starts_with_d_no_decor.puml": {
"Pkg": {
"id": "Pkg",
"name": "Pkg",
"alias": "Pkg",
"parent_id": null,
"comp_type": "Package",
"stereotype": null,
"relations": [],
"source_location": {
"file": "",
"line": 16
}
},
"Pkg.A": {
"id": "Pkg.A",
"name": "A",
"alias": "A",
"parent_id": "Pkg",
"comp_type": "Component",
"stereotype": "component",
"relations": [
{
"target": "Pkg.datst_",
"annotation": "uses",
"relation_type": "Association",
"source_role": "None",
"source_location": {
"file": "",
"line": 19
}
}
],
"source_location": {
"file": "",
"line": 17
}
},
"Pkg.datst_": {
"id": "Pkg.datst_",
"name": "Labeled",
"alias": "datst_",
"parent_id": "Pkg",
"comp_type": "Component",
"stereotype": "component",
"relations": [],
"source_location": {
"file": "",
"line": 18
}
}
}
}
22 changes: 22 additions & 0 deletions ..._diagram/relation_alias_starts_with_d_no_decor/relation_alias_starts_with_d_no_decor.puml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
' *******************************************************************************
' Copyright (c) 2026 Contributors to the Eclipse Foundation
'
' See the NOTICE file(s) distributed with this work for additional
' information regarding copyright ownership.
'
' This program and the accompanying materials are made available under the
' terms of the Apache License Version 2.0 which is available at
' https://www.apache.org/licenses/LICENSE-2.0
'
' SPDX-License-Identifier: Apache-2.0
' *******************************************************************************

@startuml

package "Pkg" as Pkg {
component "A" as A <<component>>
component "Labeled" as datst_ <<component>>
A -- datst_ : uses
}

@enduml
54 changes: 54 additions & 0 deletions ...rser/integration_test/component_diagram/relation_alias_starts_with_l_no_decor/output.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
{
"relation_alias_starts_with_l_no_decor.puml": {
"Pkg": {
"id": "Pkg",
"name": "Pkg",
"alias": "Pkg",
"parent_id": null,
"comp_type": "Package",
"stereotype": null,
"relations": [],
"source_location": {
"file": "",
"line": 16
}
},
"Pkg.A": {
"id": "Pkg.A",
"name": "A",
"alias": "A",
"parent_id": "Pkg",
"comp_type": "Component",
"stereotype": "component",
"relations": [
{
"target": "Pkg.latst_",
"annotation": "uses",
"relation_type": "Association",
"source_role": "None",
"source_location": {
"file": "",
"line": 19
}
}
],
"source_location": {
"file": "",
"line": 17
}
},
"Pkg.latst_": {
"id": "Pkg.latst_",
"name": "Labeled",
"alias": "latst_",
"parent_id": "Pkg",
"comp_type": "Component",
"stereotype": "component",
"relations": [],
"source_location": {
"file": "",
"line": 18
}
}
}
}
23 changes: 23 additions & 0 deletions ..._diagram/relation_alias_starts_with_l_no_decor/relation_alias_starts_with_l_no_decor.puml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
' *******************************************************************************
' Copyright (c) 2026 Contributors to the Eclipse Foundation
'
' See the NOTICE file(s) distributed with this work for additional
' information regarding copyright ownership.
'
' This program and the accompanying materials are made available under the
' terms of the Apache License Version 2.0 which is available at
' https://www.apache.org/licenses/LICENSE-2.0
'
' SPDX-License-Identifier: Apache-2.0
' *******************************************************************************

@startuml

package "Pkg" as Pkg {
component "A" as A <<component>>
component "Labeled" as latst_ <<component>>
A -- latst_ : uses
}

@enduml

54 changes: 54 additions & 0 deletions ...rser/integration_test/component_diagram/relation_alias_starts_with_r_no_decor/output.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
{
"relation_alias_starts_with_r_no_decor.puml": {
"Pkg": {
"id": "Pkg",
"name": "Pkg",
"alias": "Pkg",
"parent_id": null,
"comp_type": "Package",
"stereotype": null,
"relations": [],
"source_location": {
"file": "",
"line": 16
}
},
"Pkg.A": {
"id": "Pkg.A",
"name": "A",
"alias": "A",
"parent_id": "Pkg",
"comp_type": "Component",
"stereotype": "component",
"relations": [
{
"target": "Pkg.ratst_",
"annotation": "uses",
"relation_type": "Association",
"source_role": "None",
"source_location": {
"file": "",
"line": 19
}
}
],
"source_location": {
"file": "",
"line": 17
}
},
"Pkg.ratst_": {
"id": "Pkg.ratst_",
"name": "Labeled",
"alias": "ratst_",
"parent_id": "Pkg",
"comp_type": "Component",
"stereotype": "component",
"relations": [],
"source_location": {
"file": "",
"line": 18
}
}
}
}
22 changes: 22 additions & 0 deletions ..._diagram/relation_alias_starts_with_r_no_decor/relation_alias_starts_with_r_no_decor.puml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
' *******************************************************************************
' Copyright (c) 2026 Contributors to the Eclipse Foundation
'
' See the NOTICE file(s) distributed with this work for additional
' information regarding copyright ownership.
'
' This program and the accompanying materials are made available under the
' terms of the Apache License Version 2.0 which is available at
' https://www.apache.org/licenses/LICENSE-2.0
'
' SPDX-License-Identifier: Apache-2.0
' *******************************************************************************

@startuml

package "Pkg" as Pkg {
component "A" as A <<component>>
component "Labeled" as ratst_ <<component>>
A -- ratst_ : uses
}

@enduml
54 changes: 54 additions & 0 deletions ...ser/integration_test/component_diagram/relation_alias_starts_with_ri_no_decor/output.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
{
"relation_alias_starts_with_ri_no_decor.puml": {
"Pkg": {
"id": "Pkg",
"name": "Pkg",
"alias": "Pkg",
"parent_id": null,
"comp_type": "Package",
"stereotype": null,
"relations": [],
"source_location": {
"file": "",
"line": 16
}
},
"Pkg.A": {
"id": "Pkg.A",
"name": "A",
"alias": "A",
"parent_id": "Pkg",
"comp_type": "Component",
"stereotype": "component",
"relations": [
{
"target": "Pkg.riatst_",
"annotation": "uses",
"relation_type": "Association",
"source_role": "None",
"source_location": {
"file": "",
"line": 19
}
}
],
"source_location": {
"file": "",
"line": 17
}
},
"Pkg.riatst_": {
"id": "Pkg.riatst_",
"name": "Labeled",
"alias": "riatst_",
"parent_id": "Pkg",
"comp_type": "Component",
"stereotype": "component",
"relations": [],
"source_location": {
"file": "",
"line": 18
}
}
}
}
22 changes: 22 additions & 0 deletions ...iagram/relation_alias_starts_with_ri_no_decor/relation_alias_starts_with_ri_no_decor.puml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
' *******************************************************************************
' Copyright (c) 2026 Contributors to the Eclipse Foundation
'
' See the NOTICE file(s) distributed with this work for additional
' information regarding copyright ownership.
'
' This program and the accompanying materials are made available under the
' terms of the Apache License Version 2.0 which is available at
' https://www.apache.org/licenses/LICENSE-2.0
'
' SPDX-License-Identifier: Apache-2.0
' *******************************************************************************

@startuml

package "Pkg" as Pkg {
component "A" as A <<component>>
component "Labeled" as riatst_ <<component>>
A -- riatst_ : uses
}

@enduml
54 changes: 54 additions & 0 deletions .../integration_test/component_diagram/relation_alias_starts_with_right_no_decor/output.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
{
"relation_alias_starts_with_right_no_decor.puml": {
"Pkg": {
"id": "Pkg",
"name": "Pkg",
"alias": "Pkg",
"parent_id": null,
"comp_type": "Package",
"stereotype": null,
"relations": [],
"source_location": {
"file": "",
"line": 16
}
},
"Pkg.A": {
"id": "Pkg.A",
"name": "A",
"alias": "A",
"parent_id": "Pkg",
"comp_type": "Component",
"stereotype": "component",
"relations": [
{
"target": "Pkg.right_svc",
"annotation": "uses",
"relation_type": "Association",
"source_role": "None",
"source_location": {
"file": "",
"line": 19
}
}
],
"source_location": {
"file": "",
"line": 17
}
},
"Pkg.right_svc": {
"id": "Pkg.right_svc",
"name": "Labeled",
"alias": "right_svc",
"parent_id": "Pkg",
"comp_type": "Component",
"stereotype": "component",
"relations": [],
"source_location": {
"file": "",
"line": 18
}
}
}
}
22 changes: 22 additions & 0 deletions .../relation_alias_starts_with_right_no_decor/relation_alias_starts_with_right_no_decor.puml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
' *******************************************************************************
' Copyright (c) 2026 Contributors to the Eclipse Foundation
'
' See the NOTICE file(s) distributed with this work for additional
' information regarding copyright ownership.
'
' This program and the accompanying materials are made available under the
' terms of the Apache License Version 2.0 which is available at
' https://www.apache.org/licenses/LICENSE-2.0
'
' SPDX-License-Identifier: Apache-2.0
' *******************************************************************************

@startuml

package "Pkg" as Pkg {
component "A" as A <<component>>
component "Labeled" as right_svc <<component>>
A -- right_svc : uses
}

@enduml
Loading
Loading