Repository navigation
Cancel pool connection timeout timer when acquisition fails - #1713
Merged
tsegismont merged 2 commits intoOct 8, 2026
Merged
tsegismont merged 2 commits into
tsegismont merged 2 commits into
Conversation
vietj
reviewed
Sep 28, 2026
See eclipse-vertx#1706 When a pooled query fails to acquire a connection, the connection timeout timer is not cancelled, so it fails the query promise again when it fires and reports "IllegalStateException: Result is already complete". When the timer fires first, the acquisition failure fails the promise again with the same exception. Handle the acquisition failure like a successful acquisition: cancel the timer, and if it already fired, do not fail the promise again. Signed-off-by: Goutam Adwant <workwithgoutam@gmail.com>
Signed-off-by: Goutam Adwant <workwithgoutam@gmail.com>
tsegismont
force-pushed
the
fix/pool-execute-timer-on-acquire-failure-4.x
branch
from
October 8, 2026 13:15
9e5283d to
313ed29
Compare
tsegismont
reviewed
Oct 8, 2026
tsegismont
left a comment
tsegismont
left a comment
Member
There was a problem hiding this comment.
LGTM, thank you @goutamadwant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #1712
See #1706. On 4.x the double completion surfaces as
IllegalStateException: Result is already complete, thrown either by the pool timer after a failed connection attempt or by the connect path when the timeout fired first.Tests:
SqlConnectionPoolTest.testConnectFailureCancelsConnectionTimeoutSqlConnectionPoolTest.testConnectFailureAfterConnectionTimeout