Repository navigation
Add support for client-side binary OSON encoding/decoding - #1722
Closed
tsegismont wants to merge 1 commit into
Closed
tsegismont wants to merge 1 commit into
tsegismont wants to merge 1 commit into
Conversation
See eclipse-vertx#1703 On the read path, `Helper.convertOracleJsonValue` handles all reachable OSON extended types except vector, mapping them to natural Java types: `TIMESTAMP` and `DATE` to `LocalDateTime`, `TIMESTAMPTZ` to `OffsetDateTime`, `INTERVALDS` to `Duration`, `INTERVALYM` to `Period`, and `BINARY` to `Buffer`. On the write path, `JsonObject` and `JsonArray` bind parameters are encoded as OSON binary using `OracleJsonGenerator`. An intermediate UTF-8 byte array is still required because `OracleJsonFactory` provides no API to construct an `OracleJsonValue` directly from a `Map` or `List`. Assisted-by: IBM Bob Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Member
Author
|
@loiclefevre any chance for you to take a look? Thanks |
Member
Author
|
Superseded by #1749 |
Contributor
Sorry, didn't saw your message |
Member
Author
|
No worries :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1703
On the read path,
Helper.convertOracleJsonValuehandles all reachable OSON extended types except vector, mapping them to natural Java types:TIMESTAMPandDATEtoLocalDateTime,TIMESTAMPTZtoOffsetDateTime,INTERVALDStoDuration,INTERVALYMtoPeriod, andBINARYtoBuffer.On the write path,
JsonObjectandJsonArraybind parameters are encoded as OSON binary usingOracleJsonGenerator. An intermediate UTF-8 byte array is still required becauseOracleJsonFactoryprovides no API to construct anOracleJsonValuedirectly from aMaporList.Assisted-by: IBM Bob