Repository navigation
feat(dbal): replay dead letter messages to a chosen channel - #726
Merged
Merged
Conversation
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change proposed?
Important
Replaying to a channel that does not exist is refused before any message is replayed or deleted.
Dead letter messages can now be replayed to a channel the operator picks, instead of only the channel they were polled from.
Until now a replay always went back through
polledChannelName,inboundRequestChannelor the stored routing slip. A message that kept failing on its source channel could only be retried through the code that had just failed on it. A message with none of those headers could not be replayed at all.Description of Changes
DeadLetterGateway::replay()andreplayAll()take an optional target channel. Without it, behaviour is unchanged.ecotone:deadletter:replayandecotone:deadletter:replayAlltake the same target as a--targetChanneloption.InvalidArgumentExceptionthat names the channel and lists what is valid, before any message is touched.Before / after
Usage
The target is any channel the application has: an
#[InternalHandler]input channel, an asynchronous channel, or a command handler's routing key.Symfony
Laravel
Tempest
Without
--targetChannel(or with anulltarget on the gateway) each message goes back to its source channel, exactly as before.Pull Request Contribution Terms