fix(buildenv) for failing kernel builds - #259
Merged
Merged
Conversation
marly-edera
requested review from
alexandermerritt,
azenla,
bleggett,
kaniini and
tycho
as code owners
September 17, 2026 19:20
kaniini
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv is not installed in the buildenv docker file today, this PR ensures that uv is installed in the image and that it installs the latest (3.14.7) version of python. This ensures that the kernel build process does not fail. In addition, to ensure that the build process does not silently fail as it did before, the common.sh script is updated to ensure that piped output does not hide pipeline failures. We can not use
set -o pipefailhere, but we can refactor the script to exclude piped output that hides errors fromset -e.Also went ahead and bumped setup-uv to latest while I'm in here.