Repository navigation
ci: bump electron/semantic-trusted-release to v1.1.2 - #419
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EvByZWibvh3yPk8R9FdxyN
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. The SHA pin moves the release action that publishes to npm with the GitHub token, and I couldn't confirm from here that the SHA matches upstream v1.1.1, so it's still worth having a human check it.
What was reviewed:
- The single changed
uses:line in.github/workflows/release.yml. The action is still pinned to a full 40-char SHA with a version comment, the same as the other actions in this workflow. - The step's inputs (
github-tokenfrom the secret-service outputs) are unchanged. - Not verified: that
2a7b16df83a1f77339ad473654c5fbd2b32b193bis the commit tagged v1.1.1 in electron/semantic-trusted-release. This checkout has no upstream refs.
Extended reasoning...
The change is one line in .github/workflows/release.yml. It moves the pinned SHA of electron/semantic-trusted-release from the v1.1.0 commit to a new commit labeled v1.1.1. The security-sensitive part is the supply chain: this action runs the npm publish step with a GitHub token taken from secret-service, so the new SHA decides what code runs with those credentials. I couldn't check the SHA against the upstream tag from this checkout. The repo's CODEOWNERS file assigns all paths to the ecosystem working group, so this should be deferred rather than approved.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EvByZWibvh3yPk8R9FdxyN
There was a problem hiding this comment.
I reviewed the latest push and found no bugs. This action runs in the npm-publishing release job, and the path is covered by CODEOWNERS, so a maintainer should still confirm the new pin.
What was reviewed:
- The one-line change in
.github/workflows/release.yml:electron/semantic-trusted-releaseis now pinned to672a62fe…with a# v1.1.2comment. It is still a full-SHA pin, and thegithub-tokeninput is unchanged. - I couldn't check from this checkout that this SHA is the actual
v1.1.2tag commit. That's worth checking, because the job hasid-token: write. - The PR title and description still say v1.1.1 and Node 24.22.1, but the second commit moved the pin to v1.1.2. They may need updating.
Extended reasoning...
The change replaces one pinned action SHA in the release workflow. That job runs semantic-release with id-token: write in the npm-trusted-publisher environment, so the pinned SHA controls code that can publish to npm. That makes it a supply-chain-sensitive spot even though the edit is tiny. .github/CODEOWNERS assigns every path to a team, which rules out auto-approval. The new SHA could not be resolved against the upstream tag here.
Requested by Keeley Hammond · Slack thread
The release action pinned here ran the npm publish step on Node 24.10.0, which predates the October 2026 Node.js security release. v1.1.2 tracks the latest Node 24.x via
check-latest, so future Node patch releases need no further pin bumps.Generated by Claude Code