Skip to content

ci: raise warehouse test job timeout to 90 minutes - #1055

Closed
haritamar wants to merge 1 commit into
masterfrom
devin/1788861139-raise-test-timeout
Closed

haritamar wants to merge 1 commit into
masterfrom
devin/1788861139-raise-test-timeout

Conversation

@haritamar

@haritamar haritamar commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

test-warehouse.yml timeout-minutes: 60 -> 90.

The latest_official, databricks_catalog job already runs 47–60 min on recent branches (a pass at 59m46s on #1050's earlier run), and #1050 adds 19 test_metric_stability tests at ~1–4 min each on Databricks, which pushed it to 99% complete when cancelled in https://github.com/elementary-data/dbt-data-reliability/actions/runs/34201868801. The Spark job in the same run also hit the limit, but that was a 50‑minute hang in the Spark Docker build's wget downloads (infra flake), not test runtime.

Link to Devin session: https://app.devin.ai/sessions/d520e797006a405d96e2fed89117a356
Open in Devin Desktop: https://app.devin.ai/desktop/session/d520e797006a405d96e2fed89117a356?variant=devin
Requested by: @haritamar

Summary by CodeRabbit

  • Chores
    • Extended the automated test workflow timeout to 90 minutes.

Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

👋 @haritamar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 95d9e387-12eb-4be1-876c-0216c11e1dd1

📥 Commits

Reviewing files that changed from the base of the PR and between c5912df and df0540a.

📒 Files selected for processing (1)
  • .github/workflows/test-warehouse.yml

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


📝 Walkthrough

Walkthrough

The warehouse test workflow timeout increases from 60 to 90 minutes.

Changes

Warehouse test timeout

Layer / File(s) Summary
Increase test job timeout
.github/workflows/test-warehouse.yml
The warehouse test job timeout increases from 60 to 90 minutes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch devin/1788861139-raise-test-timeout

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Superseded: pushed directly to #1050 (dfe779f).

@devin-ai-integration
devin-ai-integration Bot deleted the devin/1788861139-raise-test-timeout branch September 8, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant