Skip to content

Simplify search function #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jeremypw wants to merge 3 commits into
base: master
Choose a base branch
from
+1 −10
Draft

Simplify search function #1803

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
561750c
Simply search function
jeremypw Aug 23, 2026
1121dc7
Merge branch 'master' into jeremypw/searchbar/simplify-search
jeremypw Sep 3, 2026
1f78efc
Merge branch 'master' into jeremypw/searchbar/simplify-search
zeebok Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/Widgets/SearchBar.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,19 +313,10 @@ public class Scratch.Widgets.SearchBar : Gtk.Box { //TODO In Gtk4 use a BinLayou

public bool search () {
search_entry.grab_focus ();
if (search_context == null) {
return false;
}

search_context.highlight = false;

if (!has_matches ()) {
debug ("Can't search anything in a non-existent buffer and/or without anything to search.");
if (search_context == null || text_buffer == null || search_entry.text == "") {
return false;
}

search_context.highlight = true;

Gtk.TextIter? start_iter, end_iter;
text_buffer.get_iter_at_offset (out start_iter, text_buffer.cursor_position);

Expand Down
Loading