Some unmount operation busy-dialog fixes - #2826
Open
vjr wants to merge 5 commits into
Open
Conversation
Previously it would remain open once the unmount operation completed and clicking the cancel button would have no effect. Pressing ESC would close the dialog though.
If there is only one busy process and it's pid is ours. Previously it would say "there are other processes" and list itself as "io.elementary.files". Now the unmount spinner shows and waits until the unmount operation completes.
Let it be abundantly clear to the user that an unmount operation is still in progress instead of just relying on the inconspicuous spinner. The texts of the dialog are different from the original to not mention "other processes" only "resource is busy" for this special case. The previous existing busy warning dialog and texts listing the other processes is still shown if there are in fact other processes involved.
Member
Author
|
This is a follow-up to #2823 to propose some fixes and usability improvements. |
Member
Author
|
@jeremypw another one of my drive-by proposed contributions - hopefully this is useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following changes proposed: