Repository navigation
repart: Check the installation plan before erasing the disk - #961
Closed
Sean-StarLabs wants to merge 1 commit into
Closed
Sean-StarLabs wants to merge 1 commit into
Sean-StarLabs wants to merge 1 commit into
Conversation
Member
|
Heyyyy, took a quick look through on my phone and I'm happy to merge, let me test over the weekend, thanks very much for this branch! |
Validate the source and repart plan before wipefs. Keep the definitions and
key file private to each installation, and clean them up on errors.
Test=Checked source and key-file failures, dry-run ordering and cleanup in
a private GLib fixture.
Sean-StarLabs
force-pushed
the
vale/repart-preflight-submit
branch
from
October 19, 2026 15:19
636b423 to
fcd0307
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the source and repart plan before erasing the disk, and keep definitions and the key file private to each installation. Use GIO for copying and cleanup, including failure paths.
Based on #959. Tested source/key-file failures, dry-run ordering and cleanup in a private native GLib fixture; disk installation has not been tested.