Skip to content

Handle case where no bluetooth adapters available - #256

Merged
vjr merged 2 commits into
mainfrom
vishal/handle-bluetooth-unavailable
Sep 3, 2026
Merged

Handle case where no bluetooth adapters available#256
vjr merged 2 commits into
mainfrom
vishal/handle-bluetooth-unavailable

Conversation

@vjr

@vjr vjr commented Sep 2, 2026

Copy link
Copy Markdown
Member

Proposing the following visual change:

When bluetooth adapter(s) are available/enabled, look and work as before:

bluetooth-available

When no bluetooth adapters available or it's disabled altogether:

bluetooth-unavailable

CAVEAT: Note I've only tested on my desktop PC with onboard bluetooth which I enable/disable in the UEFI settings then reboot into the OS, I don't have a USB adapter to test scenarios like plugging in and unplugging it to see if the settings update/work as expected. I do have a laptop but don't think it has a switch to enable/disable bluetooth on the fly.

@vjr vjr self-assigned this Sep 2, 2026
@vjr
vjr requested review from a team and danirabbit September 2, 2026 10:04
Comment thread src/Services/Manager.vala
Comment thread src/MainView.vala Outdated
@jeremypw

jeremypw commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@vjr works as described - just a couple of code comments. The page looks a bit blank/unbalanced to me but I'll leave it for UX to comment on that.

@vjr
vjr requested a review from jeremypw September 2, 2026 12:50

@jeremypw jeremypw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as intended. I think any UI tweaks can be left for a future PR if required.

@vjr

vjr commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

Code looks good and works as intended. I think any UI tweaks can be left for a future PR if required.

Thanks for looking at this! Merging...

@vjr
vjr merged commit c12c81a into main Sep 3, 2026
4 checks passed
@vjr
vjr deleted the vishal/handle-bluetooth-unavailable branch September 3, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants