Repository navigation
Conversation
Co-Authored-By: Hasan Bal <mailhasanbal@gmail.com>
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows elliottech/zklighter-perps#5221, which raises the server-side range of
/api/v1/orderBookOrderslimitfrom[1:250]to[1:500].The SDK checks this limit on the client side, so calls with
limit > 250fail pydantic validation before any request is sent:This PR updates
order_book_orders,order_book_orders_with_http_infoandorder_book_orders_without_preload_contentinlighter/api/order_api.py, and setsmaximumto 500 inopenapi.json. The edits are made by hand to match what the generator would output for the updated spec.Merge only after #5221 is deployed: before that, the server still rejects
limit > 250.Link to Devin session: https://app.devin.ai/sessions/5aa2c74235e7430d8230f583c769fead
Open in Devin Desktop: https://app.devin.ai/desktop/session/5aa2c74235e7430d8230f583c769fead?variant=devin
Requested by: @hasanbal