Repository navigation
Install EoSim from the pinned tag in desktop sanity jobs #128
Description
The Windows and macOS sanity jobs install EoSim from an unpinned or incorrect source. Install the repository from the intended pinned tag so both jobs exercise a reproducible dependency version.
Metadata
Metadata
Assignees
Labels
No labels
Activity
feat(ci): shared install-eosim composite action (pinned real tag)
Aswin-V commentedon Oct 5, 2026
Update 2026-10-05: the shared action this issue needs now exists:
embeddedos-org/.github.github/actions/install-eosim(composite, pins a real EoSim tag — defaultv3.0.2— validated against the tags API, fail-closed on unknown tags, from-source install default). Landed asc94f0d39.Remaining step before this can close: adopt it in the desktop sanity jobs (eAI, eBoot, eApps) so they install EoSim from the pinned tag instead of the old
EOSIM_VERSION: "0.1.0"path. Leaving this open until at least one consumer adopts it.Kartikey1306 commentedon Oct 7, 2026
@Aswin-V a first consumer is up for review: embeddedos-org/eApps#49 switches eApps' two Linux EoSim jobs (EoS Sim, Guest OS) to
embeddedos-org/.github/.github/actions/install-eosim@masterwithversion: ${{ env.EOSIM_VERSION }}.The cross-OS install matrix and the Windows and macOS jobs stay on the direct clone for now. The action's resolve step calls
python3, whichsetup-pythondoes not guarantee on Windows, so that would be a follow-up in the action itself.Kartikey1306 commentedon Oct 7, 2026
@Aswin-V all three consumers now have a PR adopting
install-eosim@masterwithversion: ${{ env.EOSIM_VERSION }}(3.0.2):nested-simulationandnested-guest-install(eosim-sanity),simulate(qemu-test)nested-simulation,nested-guest-installI ran the action's steps from c94f0d3 locally: the tag resolves to
v3.0.2, the installed version reports3.0.2, andeosim listpasses. On that install, every post-installrun:step of the moved jobs passes for each matrix entry (eAI 42/42, eBoot 10/10).Still on the direct clone in all three repos: the cross-OS install matrices and the Windows and macOS jobs. The action's resolve step runs
python3, whichsetup-pythondoesn't guarantee on Windows. If you'd like, I can follow up in the action itself, for example by callingpythonwhenrunner.os == 'Windows'.Kartikey1306 commentedon Oct 7, 2026
Correction to my comment above: the Windows carve-out was based on a wrong assumption. A probe run of the action on
windows-latest,macos-latestandubuntu-latestpasses on all three: https://github.com/Kartikey1306/.github/actions/runs/37668634240.setup-pythonprovidespython3on Windows. I'm extending eApps#49, eAI#52 and eBoot#149 to every EoSim job, including the Windows, macOS and cross-OS matrix jobs.ci(eosim): install EoSim through the org's pinned install-eosim action (
ci(eosim): install EoSim through the shared install-eosim action in t…
ci(eosim): install EoSim through the org's pinned install-eosim action (
ci(eosim-sanity): pin EoSim by the v3.0.2 tag, not a commit — Refs #128
Aswin-V commentedon Oct 16, 2026
Status update from the daily improvement loop (2026-10-16):
The fix landed on master on 2026-10-15 in commit
7afae3e5("ci(sanity): pin EoSim install to the v3.0.2 tag"):.github/workflows/eosim-sanity.ymlnow setsEOSIM_REF: "v3.0.2"instead of the pinned commitc5e27702b9ab8e3e9dcf34b7686a1c1c1040515c.Evidence:
v3.0.2contains the EoSim#35 fix for the EoSim#34 "lists 0 platforms, exits 0" bug:compare c5e27702...v3.0.2is ahead 3 / behind 0, so the old pinned commit is an ancestor of the tag.38782438748, 2026-10-15).This issue stays open for now: per the adoption criterion recorded on 2026-10-05, closing waits on consumer adoption of the tag pin. The pin itself is in place and verified; no further code change is pending from the daily loop.
Aswin-V commentedon Oct 17, 2026
Status update from the daily loop (2026-10-17): the EoSim pin move landed 2026-10-15 in
7afae3e5—eosim-sanity.ymlnow pins EoSim by tagv3.0.2instead of commitc5e27702. Evidence: EoSim Sanity run 38782438748 at head7afae3e5completed success on 2026-10-15 (re-verified against the Actions API today). Tagv3.0.2contains the EoSim#35 fix the pin exists for.Per Aswin's 2026-10-05 comment, closing waits on consumer adoption evidence, so this issue stays open with the pin half complete and verified. Next evidence needed: a downstream consumer build resolving EoSim via the
v3.0.2tag.