Repository navigation
fix(setup): say when a cached clone was reused and not updated - #181
Merged
Merged
Conversation
DepsManager.setup() leaves an existing ~/.ebuild/repos/<name> alone on purpose (it must not move a pinned branch or tag), but the CLI printed the same 'Repos are ready' as for a fresh clone. A month-old eos then fails later in 'ebuild sim' with sim.yaml not found. Warn with the clone's commit and date and name 'ebuild repos update'. Clone/update logic is unchanged; --eos-path/--eboot-path links are not reported as cached. Fixes #180 Signed-off-by: Srikanth Patchava <srpatcha@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #180
Problem
ebuild setupon a machine that already has~/.ebuild/repos/eosreportsSetup complete. Repos are ready.exactly as for a fresh clone.DepsManager.setup()intentionally does not pull an existing clone, so nothing told the user their eos was from 2026-09-11;ebuild sim qemu_cortex_m3then failed withsim.yaml not found. Found while re-running the MVP pipeline on WSL.Change
ebuild/cli/commands.py: before eachmgr.setup(), note whether the cache dir already existed (and no--*-pathlink was given). If so, after setup print a[warn]with the clone's%h %csandebuild repos update. The clone/update logic is untouched.Verification (WSL, Python 3.12)
Real scenario, temp HOME with eos reset to
9ed6831:(First run in that HOME cloned eboot fresh and printed no eboot warning.)
tests/unit/test_setup_stale_cache.py: 4 passed (fresh clone -> no warning; existing git clone -> commit+date+command; existing non-git dir -> 'unknown commit';--eos-path-> no warning). With the CLI change reverted, 2 of them fail.python -m pytest tests/: 897 passed, 2 skipped.ruff check .: All checks passed.After
ebuild repos updateon the same machine,embeddedos-stackMVP pipeline--strictpassed all five stages against today's masters (eosdc13c59).