Repository navigation
List the kind-change test among the layer-mode writers - #108
Merged
bobsingor merged 1 commit intoNov 3, 2026
Merged
Conversation
SetSubtypeChangesTheKindInPlace builds its document with NewTestDocument() and edits it, so in layer mode it leaves 5 objects in the layer: a writer, not a read that writes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release has failed on
embedpdf/mainsince #103: its layer-mode step reportsleaves 5 objects in the layer but is not a known writer: EPDFAnnotEmbedderTest.SetSubtypeChangesTheKindInPlace.That test builds its document with
NewTestDocument()and changes an annotation's kind, so in layer mode it leaves 5 objects in the layer: it writes, as intended, and it isn't a read that writes. This lists it intesting/embedpdf_layer_mode_writers.txt, in sorted order.Checked
run_layer_mode.pyon darwin-arm64 at main plus this commit, over the 15 embedder tests added since 28b8b80 (Change an annotation's kind in place #103 to Give the caption golden's polygon and polyline a stroke colour #107): all pass normally and in layer mode, 12 write, and every writer is listed.